Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with updated dependencies #1231

Closed
4 tasks done
tobiasdiez opened this issue Sep 16, 2023 · 8 comments
Closed
4 tasks done

New release with updated dependencies #1231

tobiasdiez opened this issue Sep 16, 2023 · 8 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@tobiasdiez
Copy link

Initial checklist

Problem

Using this package via nuxt/content results in some issues since the last released version depends on older version of dependencies, see nuxt/content#1562.

Solution

Should be resolved by 943f6ac, so only thing needed is a new release 😄

Alternatives

Couldn't find a workaround.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 16, 2023
@wooorm
Copy link
Member

wooorm commented Sep 16, 2023

Hey! Working on it, as you saw. Working on 100s of repos. I’ll close this for now, it’s not beneficial to have separate issues in some repos open.

I don’t understand why Nuxt results in an error. With semver, you shouldn’t get a newer micromark that doesn’t work with current remark.

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2023
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Sep 16, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 16, 2023
@tobiasdiez
Copy link
Author

I thought a new release might be easy to do - so sorry for the added noise.

The problem in the context of nuxt/content is that some other packages depend on micromark 4 while this package here still uses v3, and nuxt has some troubles with these double versions.

@wooorm
Copy link
Member

wooorm commented Sep 16, 2023

no problem about the issue/“noise”, it’s just easier for me to not try and track a couple issues scattered across different projects!

The release is ready, it’s just that I also want to release a couple remark plugins that deeply integrate with this at the same time. And that I don’t have much time this weekend. Should be monday.

and nuxt has some troubles with these double versions.

Ah. Hmm. Weird!

@lucgagan
Copy link

lucgagan commented Sep 20, 2023

@wooorm Is this related to the issue I am getting here?

src/routines/formatMarkdown.ts:10:10 - error TS2769: No overload matches this call.
  Overload 1 of 3, '(preset?: Preset | null | undefined): Processor<Root, undefined, undefined, Root, string>', gave the following error.
    Argument of type 'import("/Developer/rayrun/blog/node_modules/.pnpm/[email protected]/node_modules/unified/index").Preset' is not assignable to parameter of type 'import("/Developer/rayrun/blog/node_modules/.pnpm/[email protected]/node_modules/unified/lib/index").Preset'.
  Overload 2 of 3, '(list: PluggableList): Processor<Root, undefined, undefined, Root, string>', gave the following error.
    Argument of type 'Preset' is not assignable to parameter of type 'PluggableList'.
  Overload 3 of 3, '(plugin: Plugin<[], undefined, undefined>, ...parameters: [] | [boolean]): Processor<Root, undefined, undefined, Root, string>', gave the following error.
    Argument of type 'Preset' is not assignable to parameter of type 'Plugin<[], undefined, undefined>'.

10     .use(remarkPresetLintMarkdownStyleGuide)
import { remark } from 'remark';
import remarkLintListItemBulletIndent from 'remark-lint-list-item-bullet-indent';
import remarkLintListItemIndent from 'remark-lint-list-item-indent';
import remarkPresetLintMarkdownStyleGuide from 'remark-preset-lint-markdown-style-guide';
import remarkPresetLintRecommended from 'remark-preset-lint-recommended';

export const formatMarkdown = async (markdown: string): Promise<string> => {
  const file = await remark()
    .use(remarkPresetLintRecommended)
    .use(remarkPresetLintMarkdownStyleGuide)
    .use(remarkLintListItemIndent, 'space')
    .use(remarkLintListItemBulletIndent, 'space')
    .process(markdown);

  return file.value.toString();
};

@lucgagan
Copy link

I am getting it for seemingly every plugin.

@lucgagan
Copy link

at 09:54:27 ❯ cat package.json | grep remark
    "remark": "^15.0.1",
    "remark-gfm": "^4.0.0",
    "remark-html": "^15.0.2",
    "remark-lint-list-item-bullet-indent": "^4.1.2",
    "remark-lint-list-item-indent": "^3.1.2",
    "remark-parse": "^11.0.0",
    "remark-preset-lint-markdown-style-guide": "^5.1.3",
    "remark-preset-lint-recommended": "^6.1.3",
    "remark-toc": "^9.0.0",

@wooorm
Copy link
Member

wooorm commented Sep 20, 2023

Yes, it is related. Wait a bit for me to update everything. Should be done in 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants