Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edit] support to change the date format (eg : to dd/mm/yyyy) #3

Open
LoganTann opened this issue Nov 9, 2020 · 3 comments
Open

[edit] support to change the date format (eg : to dd/mm/yyyy) #3

LoganTann opened this issue Nov 9, 2020 · 3 comments

Comments

@LoganTann
Copy link

LoganTann commented Nov 9, 2020

Possible feature request : ability to change the (input) date format from a string pattern using a command, like the PHP fonction date("")

Original issue

Hello,

Is it possible to make a French support for this bot ?

In France, we have the 24 hours format (02:14PM → 15:14), and the time format is dd/mm/yyyy (whereas the English one is mm/dd/yyyy)

Maybe I can contribute, at least for a possible translation ?

@JellyWX
Copy link
Contributor

JellyWX commented Nov 9, 2020

Hi, the bot already uses both of these since I am British and we use the same systems. There may be some exceptions when it comes to the date, since the library we use for NLP by default uses mm/dd/yyyy, but it should try and guess which to use and is not too much of an issue since most of the internet is American. Other dates may be ISO formatted (YYYY-MM-DD) since this is unambiguous

@LoganTann LoganTann changed the title Support for french time system ? [edit] support to change the date format (eg : to dd/mm/yyyy) Nov 9, 2020
@LoganTann
Copy link
Author

Yes, I just noticed that it actually supports 24 hours format 👍 sorry for the disturbing

The only thing to implement is the ability to change the date format from a string ("dd/mm/yyyy")
Since your bot seems to support ISO format, I think I'll use your suggestion while waiting for a possible implementation

I edited the title of the issue, and I'll edit soon its content.

@JellyWX
Copy link
Contributor

JellyWX commented Nov 9, 2020

to be unambiguous with the natural processor, you can always use something like october 12th instead of 12/10 (which in american would be 10th of december) :)

its slightly longer-hand but its better than nothing i suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants