Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.signal is never fired in dev server #9438

Closed
DanielBaulig opened this issue May 15, 2024 · 4 comments · Fixed by #9976
Closed

request.signal is never fired in dev server #9438

DanielBaulig opened this issue May 15, 2024 · 4 comments · Fixed by #9976
Labels
awaiting release This issue has been fixed and will be released soon bug:unverified feat:routing package:dev

Comments

@DanielBaulig
Copy link

Reproduction

https://stackblitz.com/edit/remix-run-remix-jkyczz?file=app%2Froutes%2Fstream.tsx

Based on discussion: #8461

The effects of the bug are twofold:

  • Actual abort signal behavior cannot be tested and verified using the dev server.
  • The dev server might leak resources that should have been freed when the request was cancelled.

Not that the bug only applies to the dev server. Using the express server the request abort signal is fired correctly.

System Info

See Stackblitz

Used Package Manager

npm

Expected Behavior

Dev server should print 'Received Abort!' when the response gets cancelled a second in.

Actual Behavior

Silence.

@remorses
Copy link

Faced the same issue, this is very important please fix

@brophdawg11
Copy link
Contributor

Resolved by #9976 and will be available in the next release 👍

@brophdawg11 brophdawg11 added the awaiting release This issue has been fixed and will be released soon label Sep 13, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon bug:unverified feat:routing package:dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants