Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Keywords" entries should be restructured. #27

Open
Andy-Rossi opened this issue Oct 11, 2023 · 7 comments
Open

"Keywords" entries should be restructured. #27

Andy-Rossi opened this issue Oct 11, 2023 · 7 comments

Comments

@Andy-Rossi
Copy link
Contributor

It is hard to translate these entries called "keywords", since there is no context to them, and in other languages sometimes one word can become multiple words (and vice-versa: multiple words can be translated to one word).

  • I wonder if those translations will even work well when implemented, since if the only link between the original text and the translation is the order of the words, it will probably cause translation bugs to happen.
  • Ideally, each complete sentence from a button should be it's own entry.
    • e.g.: Sync | Log | Delete | Account Reset...etc. -> each of those should be a different entry.

image

@KuranosukeOhta
Copy link
Contributor

I use Japanese and agree with this opinion.
Unlike English, Japanese does not require half-width spacing, so the translation needs to be done in whole sentences, not just words.
Note: the difference between half-width and full-width
https://mailmate.jp/blog/half-width-full-width-hankaku-zenkaku-explained

@lovedebug
Copy link
Contributor

Same issue for Chinese

@dewil-official
Copy link
Member

I agree with the lack of context, I'll think about a solution here. Maybe there's a way to add a description to these fields. This example, SETTINGS.ACCOUNT.DANGER_ZONE.KEYWORDS is supposed to be a space-separated list of keywords that are used in the Command Omnibar to find any features that are hidden in that "Danger Zone" section of the account settings. So e.g. when you search for Reset, it'll suggest you to open the "Danger Zone" where that is possible.

I'm unsure about what to do with the half-width and full-width characters. Would adding a better description here also help?

@KuranosukeOhta
Copy link
Contributor

Okay, I understand some of the uses of the KEYWORDS attribute.
In the example of SETTINGS.ACCOUNT.DANGER_ZONE.KEYWORDS, each of the original sentences is a noun or adjective, and therefore can be expressed relatively in one word in Japanese.
However, in the case of articles such as a, an, the, etc., there is no translation for them in Japanese, making it very difficult to enter keywords in the example shown in the image.
image
If the use of these articles is limited to use as search keywords, it may be a good idea to omit translation for these words.

Regarding the full-width/half-width issue, if careful to use only half-width space characters, it seems that there will probably be no display problems.
For now, I think a good solution may be to check the actual display and make adjustments each time.

@sobjornstad
Copy link
Member

sobjornstad commented Jun 3, 2024

@KuranosukeOhta You should feel free to enter whatever keywords you think a Japanese user would search for when trying to find this setting. It absolutely does not need to be a 1:1 translation of the English words that are present in the field.

(We shouldn't have articles in these at all even in English, FWIW, they don't help the search work better)

Like @dewil-official, I don't think there is any problem with the actual fields or how they're being used, it's just hard to understand what you're supposed to do with this string when you see it in Inlang

@sobjornstad
Copy link
Member

sobjornstad commented Jun 3, 2024

@Andy-Rossi The order of the words here is not relevant at all, so there is no issue with them “corresponding” – each individual word can be matched to a word in the string you enter.

And no content in the keywords field is ever displayed anywhere on screen – it's purely used for search matching. So I don't think the half/full-width should be an issue; the only question would be if our search matching is sensitive to which character type you used

@Andy-Rossi
Copy link
Contributor Author

@sobjornstad @dewil-official ooh, I get it now. That makes more sense. It is hard to deduce this from just the variable name, and since these are the same names used in the buttons in the settings menus, I thought it was a translation for those.

Maybe there's a way to add a description to these fields. - @dewil-official

  • Would that be possible? I think that would be enough to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants