Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade templates to ESLint 9 #4016

Open
JonnyBurger opened this issue Jun 19, 2024 · 20 comments
Open

Upgrade templates to ESLint 9 #4016

JonnyBurger opened this issue Jun 19, 2024 · 20 comments

Comments

@JonnyBurger
Copy link
Member

We get bunch of deprecation notices now with ESLint 8.
VS Code extensions seems to support it now as well..

@JonnyBurger
Copy link
Member Author

$200 if someone is able to upgrade the Hello World template to use ESLint 9 (ideally with Flat Config, but if there is a different way, then it's also okay): https://github.com/remotion-dev/template-helloworld

Criteria: The lint command as well as the VS Code error reporting with the ESLint extension should also keep working.

Maybe an update to @remotion/eslint-plugin and @remotion/eslint-config is necessary, but it should be backwards compatible hopefully. In that case, just comment what changes need to be made.

💎 This issue has a bounty on it!

Read our contributing guidelines:

/bounty 50

Copy link

algora-pbc bot commented Jun 19, 2024

💎 $200 bounty • Remotion

Steps to solve:

  1. Get assigned: If you'd like to work on this issue, comment /attempt below to get assigned
  2. Submit work: Create a pull request including /claim #4016 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Additional opportunities:

  • 🔴 Livestream on Algora TV while solving this bounty & earn $200 upon merge! Make sure to have your camera and microphone on. Comment /livestream once live

Thank you for contributing to remotion-dev/remotion!

Add a bountyShare on socials

@abhishek818
Copy link
Contributor

@JonnyBurger can I get this assigned??

@JonnyBurger
Copy link
Member Author

Yes!

@volfcan
Copy link

volfcan commented Jun 21, 2024

/attempt

@abhishek818
Copy link
Contributor

abhishek818 commented Jun 22, 2024

Hey @volfcan, you can take up other bounty issues, this one is assigned to me. There are two type of repos, one where everybody takes a attempt at solution and other where a person is assigned first. This repo is the other type.

@JonnyBurger
Copy link
Member Author

@abhishek818 is right!

@abhishek818
Copy link
Contributor

current status: close to solution, will push a PR soon.

@JonnyBurger
Copy link
Member Author

Thanks for the update!

@abhishek818
Copy link
Contributor

algora tv is down as of now, can i push a PR until then? I will livestream after algora is back, is it then eligible for livestream bounty? @zcesur

@zcesur
Copy link
Contributor

zcesur commented Jun 25, 2024

@abhishek818 algora tv is back up! regarding the livestream bounty (which is something very new), let's hear from @JonnyBurger on whether he wants these rewards (if not we'll remove it from the bounty comments in this repo)

@ysrael12
Copy link

/attempt

@abhishek818
Copy link
Contributor

abhishek818 commented Jun 26, 2024

/livestream

Watch abhishek818 on Algora TV
Click here to watch abhishek818

abhishek818 added a commit to abhishek818/remotion that referenced this issue Jun 26, 2024
…dev#4016)

changes in patch eslint file related to shareable config logic
Copy link

algora-pbc bot commented Jun 26, 2024

💡 @abhishek818 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Jun 26, 2024

🎉🎈 @abhishek818 has been awarded $200! 🎈🎊

@abhishek818
Copy link
Contributor

@zcesur is it eligible for livestream bounty? PR is merged.

@abhishek818
Copy link
Contributor

@JonnyBurger tagging you..
just not sure whom to tag for above.

@zcesur
Copy link
Contributor

zcesur commented Jun 27, 2024

hey @abhishek818 Jonny didn't confirm the livestream bounty, also your livestream is unfortunately not eligible since you didn't include camera+mic per the requirements (see bot comment), nonetheless thank you for trying it out!

@apperside
Copy link

Why this issue is still open?

@JonnyBurger
Copy link
Member Author

Not all of our templates are updated yet, also the one we did not logged some peer dependency issues, so we downgraded for now, waiting for our dependencies to stabilize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants