tools: Make invocation of host compiler correct #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOSTCC should be used in any of the tools inside the tools/ directory instead of CC. That way it is possible to override both values from the command line when building the Trusted Firmware and the tools at the same time. Also, use HOSTCCFLAGS instead of CFLAGS. Also, instead of printing the strings CC and LD in the console during the compilation of the tools, HOSTCC and HOSTLD have to be used for clarity. This is how it is done in other projects like U-Boot or Linux. Change-Id: Icd6f74c31eb74cdd1c353583399ab19e173e293e Signed-off-by: Antonio Nino Diaz <[email protected]> Signed-off-by: Andrea Tomassetti <[email protected]>
|
This patch should be submitted to Have you also seen: |
|
This patch should be submitted to
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a
Have you also seen:
ARM-software/tf-issues#656
?
Alexei
…________________________________
From: Andrea Tomassetti <[email protected]>
Sent: 11 June 2019 08:19
To: renesas-rcar/arm-trusted-firmware
Cc: Subscribed
Subject: [renesas-rcar/arm-trusted-firmware] tools: Make invocation of host compiler correct (#13)
HOSTCC should be used in any of the tools inside the tools/ directory
instead of CC. That way it is possible to override both values from the
command line when building the Trusted Firmware and the tools at the
same time. Also, use HOSTCCFLAGS instead of CFLAGS.
Also, instead of printing the strings CC and LD in the console during
the compilation of the tools, HOSTCC and HOSTLD have to be used for
clarity. This is how it is done in other projects like U-Boot or Linux.
Change-Id: Icd6f74c31eb74cdd1c353583399ab19e173e293e
Signed-off-by: Antonio Nino Diaz [email protected]<mailto:[email protected]>
Signed-off-by: Andrea Tomassetti [email protected]<mailto:[email protected]>
________________________________
You can view, comment on, or merge this pull request online at:
#13
Commit Summary
* tools: Make invocation of host compiler correct
File Changes
* M tools/cert_create/Makefile<https://github.com/renesas-rcar/arm-trusted-firmware/pull/13/files#diff-0> (20)
* M tools/fiptool/Makefile<https://github.com/renesas-rcar/arm-trusted-firmware/pull/13/files#diff-1> (14)
Patch Links:
* https://github.com/renesas-rcar/arm-trusted-firmware/pull/13.patch
* https://github.com/renesas-rcar/arm-trusted-firmware/pull/13.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#13?email_source=notifications&email_token=ACTXTH2ERKK73CZ3ATBYKSTPZ5GX5A5CNFSM4HW3ICV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYXNONQ>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACTXTH5OIKIBG5BS2CNBHXLPZ5GX5ANCNFSM4HW3ICVQ>.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
|
|
Hi @AlexeiFedorov I cherry-picked the commit from the official ARM-software repo. This commit should be applied to this Renesas fork as well in order to be able to correctly compile the Do you know if Renesas has enabled the secure boot and how to enable it? I found a |
|
I can see |
|
The thing you posted is the exact thing I was talking about. Not very helpful. |
marex
pushed a commit
to marex/arm-trusted-firmware
that referenced
this pull request
Jun 13, 2019
…rcar#13 Do not power off the CPU1 since there is no way to wake it up (wake-up is causing CPU0 reset as well duo to HW bug). Quote from errata Ref renesas-rcar#13 [In power saving mode, both cores must be powered off]: "When Core 0 is on and Core 1 is in power-off state, a Core 1 wake-up resets Core 0 as well and puts Core 0 back to ROM". To overcome described HW bug instead of powering the CPU off, let it reach WFI instruction, which is invoked by generic psci_do_cpu_off function after platform handler finishes. This will put the core in low power state and give a chance to wake it up. Before this change, after running secondary kernel via kexec, only one core was up, now both cores are up. Change-Id: I87f144867550728055d9b8a2edb84a14539acab7 Signed-off-by: Grzegorz Jaszczyk <[email protected]> Reviewed-by: Kostya Porotchkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOSTCC should be used in any of the tools inside the tools/ directory
instead of CC. That way it is possible to override both values from the
command line when building the Trusted Firmware and the tools at the
same time. Also, use HOSTCCFLAGS instead of CFLAGS.
Also, instead of printing the strings CC and LD in the console during
the compilation of the tools, HOSTCC and HOSTLD have to be used for
clarity. This is how it is done in other projects like U-Boot or Linux.
Change-Id: Icd6f74c31eb74cdd1c353583399ab19e173e293e
Signed-off-by: Antonio Nino Diaz [email protected]
Signed-off-by: Andrea Tomassetti [email protected]