Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of BAIT in core.py #4

Open
ADC27 opened this issue Jan 5, 2024 · 0 comments
Open

Calculation of BAIT in core.py #4

ADC27 opened this issue Jan 5, 2024 · 0 comments

Comments

@ADC27
Copy link

ADC27 commented Jan 5, 2024

# If it's humid, both hot and cold feel more extreme
discomfort = N - setpoint_T
N = (
    setpoint_T
    + discomfort
    + (
        discomfort
        # Convert humidity from g/kg to kg/kg
        * ((weather["humidity"] / 1000) - setpoint_H)
        * humidity_discomfort
    )
)

In the above piece of code, N - setpoint_T is multiplied instead of weather["temperature"], but I believe in the equation on the article it was written temperature. Could you please clarify? Here N is weather["temperature"] plus parameters which take solar gains and wind chills into consideration.

Also setpoint_H 's unit is g/kg, then why only convert weather["Humidity"] to kg/kg? I believe it is a mistake.

Also, setpoint_H = (1.1 + 0.06 * T).rpow(np.e); but in the article it is written as H = 1.1+0.6T; 0.6T instead of 0.06T. Which one is correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant