Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook fails to install with node LTS v22 #2527

Closed
wwuck opened this issue Nov 6, 2024 · 2 comments
Closed

Hook fails to install with node LTS v22 #2527

wwuck opened this issue Nov 6, 2024 · 2 comments

Comments

@wwuck
Copy link
Contributor

wwuck commented Nov 6, 2024

I have node installed with fnm. When I was using node v20 I had no problems installing this hook with pre-commit. After I switched to v22 with fnm the hook install just hangs and doesn't complete. Reverting node to v20 with fnm allows the hook to install again.

Removing all node versions from fnm also doesn't work because then pre-commit goes to install node v23 itself which is also causing hook install to hang.

I can't see any way to get verbose/debug info from pre-commit on hook install and it looks like there won't be any feature added to support that. (pre-commit/pre-commit#3254)

@jonesbusy
Copy link

Same here. For some reason it work with 22.10.0 but hang with 22.11.0

Not sure exactly where to look

Not sure if nodeenv issue or precommit issue. Could be similar to #2460

@viceice
Copy link
Member

viceice commented Dec 5, 2024

Seems like a tooling error, like the other mentioned issue. There's nothing we can do here.

@viceice viceice closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants