Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate Approve Bot for Bitbucket Server #214

Open
brushmate opened this issue May 5, 2022 · 4 comments
Open

Renovate Approve Bot for Bitbucket Server #214

brushmate opened this issue May 5, 2022 · 4 comments

Comments

@brushmate
Copy link

brushmate commented May 5, 2022

I have forked this repository to yieldlab/renovate-approve-bot-bitbucket-server and ported it to support Bitbucket Server. But I feel like it belongs to the renovatebot organization. Would you like to take it over?

Maybe it would also makes sense to merge both approve bots into a single one that can be used for Bitbucket Cloud and Server. WDYT?

@rarkins
Copy link
Collaborator

rarkins commented May 5, 2022

If there's a lot of common platform code then combining them would make sense, otherwise keeping them separate is also OK

@brushmate
Copy link
Author

Basically only getPullRequests() and approvePullRequest() are different, the rest is pretty much the same.

@rarkins
Copy link
Collaborator

rarkins commented May 5, 2022

I think if you can merge the two and submit a clean pull request here, it would be great. Ideally default to Bitbucket Cloud so that existing users don't need to make configuration changes afterwards

@brushmate
Copy link
Author

Sounds good! I will prepare something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants