Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from JavaScript to TypeScript #58

Open
HonkingGoose opened this issue Nov 24, 2021 · 4 comments
Open

Migrate from JavaScript to TypeScript #58

HonkingGoose opened this issue Nov 24, 2021 · 4 comments
Labels
help wanted Extra attention is needed priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready Ready to start implementation type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

I see that the code uses JavaScript. The main Renovate repo uses TypeScript.

Do we want to migrate from JavaScript to TypeScript?
@HonkingGoose HonkingGoose added the enhancement New feature or request label Nov 24, 2021
@maxbrunet
Copy link
Collaborator

The repo uses a tech stack as close as possible to what was already in @renovatebot, but I have struck a middle ground between the simplicity of https://github.com/renovatebot/renovate-approve-bot/ and the complexity of https://github.com/renovatebot/renovate. I think the overhead of TypeScript is not worth it here. The product itself is just this index.js of ~100 lines 😅

@maxbrunet maxbrunet mentioned this issue Nov 24, 2021
Closed
@HonkingGoose
Copy link
Collaborator Author

@rarkins and @viceice What do you think?

@viceice
Copy link
Member

viceice commented Nov 26, 2021 •
edited
Loading

Would be great for code safety, but i've no time to work on this. 🤷‍♂️

@rarkins
Copy link
Collaborator

rarkins commented Nov 26, 2021

I'm fine to leave as is

@HonkingGoose HonkingGoose added help wanted Extra attention is needed priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code status:ready Ready to start implementation and removed enhancement New feature or request labels Nov 29, 2021
@HonkingGoose HonkingGoose changed the title Proposal: migrate from JavaScript to TypeScript? Migrate from JavaScript to TypeScript Nov 29, 2021
@maxbrunet maxbrunet mentioned this issue May 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready Ready to start implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@viceice @rarkins @maxbrunet @HonkingGoose