Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency dashboard, checking a rate limited dependency does not unlimit #7251

Closed
ChristianMurphy opened this issue Sep 11, 2020 · 1 comment · Fixed by #7253
Closed

Dependency dashboard, checking a rate limited dependency does not unlimit #7251

ChristianMurphy opened this issue Sep 11, 2020 · 1 comment · Fixed by #7253
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@ChristianMurphy
Copy link
Contributor

What Renovate type, platform and version are you using?

hosted renovate for GitHub.
with "renovateVersion": "23.21.2"

Describe the bug

openEquella has a rate limit of 2 PRs per hour and 20 open PRs
https://github.com/openequella/openEQUELLA/blob/5f9a14c4583abe6e3a69e38fe21e5fafb8ebc003/renovate.json#L3-L4

One of the rate limited is eslint-plugin-react-hooks (part of the react-monorepo group).
Checking the dependency on the dashboard issue openequella/openEQUELLA#1532 to bypass the rate limit successfully generates a branch/commit openequella/openEQUELLA@e4037f7, but does not open a pull request.

Relevant debug logs

DEBUG: Branch has been checked in Dependency Dashboard: unlimit(branch="renovate/react-monorepo")
DEBUG: Reached PR limit - skipping PR creation(branch="renovate/react-monorepo")
DEBUG: processBranch with 1 upgrades(branch="renovate/react-monorepo")
DEBUG: Setting current branch to develop(branch="renovate/react-monorepo")
DEBUG: latest commit(branch="renovate/react-monorepo")
{
  "branchName": "develop",
  "latestCommitDate": "2020-09-07T10:08:24+10:00"
}
DEBUG: getBranchPr(renovate/react-monorepo)(branch="renovate/react-monorepo")
DEBUG: findPr(renovate/react-monorepo, undefined, open)(branch="renovate/react-monorepo")
DEBUG: branchExists=false(branch="renovate/react-monorepo")
DEBUG: Branch has been checked in Dependency Dashboard: unlimit(branch="renovate/react-monorepo")
DEBUG: Branch has 1 upgrade(s)(branch="renovate/react-monorepo")
DEBUG: recreateClosed is false(branch="renovate/react-monorepo")
DEBUG: findPr(renovate/react-monorepo, Update dependency eslint-plugin-react-hooks to v4.1.2, !open)(branch="renovate/react-monorepo")
DEBUG: prAlreadyExisted=false(branch="renovate/react-monorepo")
DEBUG: Checking schedule(at any time, null)(branch="renovate/react-monorepo")
DEBUG: No schedule defined(branch="renovate/react-monorepo")
DEBUG: Branch needs creating(branch="renovate/react-monorepo")
DEBUG: Using reuseExistingBranch: false(branch="renovate/react-monorepo")
DEBUG: manager.getUpdatedPackageFiles()(branch="renovate/react-monorepo")
{
  "reuseExistingBranch": false,
  "branchName": "renovate/react-monorepo"
}
DEBUG: npm.updateDependency(): devDependencies.eslint-plugin-react-hooks = 4.1.2(branch="renovate/react-monorepo")
DEBUG: Updating packageFile content(packageFile="package.json", branch="renovate/react-monorepo")
{
  "depName": "eslint-plugin-react-hooks"
}
DEBUG: Updated 1 package files(branch="renovate/react-monorepo")
DEBUG: Getting updated lock files(branch="renovate/react-monorepo")
DEBUG: lock file dirs(branch="renovate/react-monorepo")
{
  "dirs": {
    "yarnLockDirs": [],
    "npmLockDirs": [
      "package-lock.json"
    ],
    "pnpmShrinkwrapDirs": [],
    "lernaDirs": []
  }
}
DEBUG: Writing package.json files(branch="renovate/react-monorepo")
{
  "packageFiles": [
    "Source/Plugins/Core/com.equella.core/js/package.json",
    "Source/Plugins/Core/com.equella.core/swaggerui/package.json",
    "autotest/IntegTester/ps/package.json",
    "oeq-ts-rest-api/package.json",
    "package.json"
  ]
}
DEBUG: Writing Source/Plugins/Core/com.equella.core/js/package-lock.json(branch="renovate/react-monorepo")
DEBUG: Writing Source/Plugins/Core/com.equella.core/swaggerui/package-lock.json(branch="renovate/react-monorepo")
DEBUG: Writing autotest/IntegTester/ps/package-lock.json(branch="renovate/react-monorepo")
DEBUG: Writing oeq-ts-rest-api/package-lock.json(branch="renovate/react-monorepo")
DEBUG: Writing package-lock.json(branch="renovate/react-monorepo")
DEBUG: Writing any updated package files(branch="renovate/react-monorepo")
DEBUG: Writing package.json(branch="renovate/react-monorepo")
DEBUG: No npmrc file found in repository(branch="renovate/react-monorepo")
DEBUG: Writing updated .npmrc file to /mnt/renovate/gh/openequella/openEQUELLA/.npmrc(branch="renovate/react-monorepo")
DEBUG: Generating package-lock.json for .(branch="renovate/react-monorepo")
DEBUG: Spawning npm install to create /mnt/renovate/gh/openequella/openEQUELLA/package-lock.json(branch="renovate/react-monorepo")
DEBUG: Updating lock file only(branch="renovate/react-monorepo")
DEBUG: Using node constraint "12.18.3" from .nvmrc(branch="renovate/react-monorepo")
DEBUG: Using docker to execute(branch="renovate/react-monorepo")
DEBUG: Found npm version constraint - checking for a compatible docker.io/renovate/node image to use(branch="renovate/react-monorepo")
{
  "constraint": "12.18.3"
}
DEBUG: getLabels(https://index.docker.io, renovate/node, latest)(branch="renovate/react-monorepo")
DEBUG: Missing versioning(branch="renovate/react-monorepo")
DEBUG: Found compatible npm version(branch="renovate/react-monorepo")
{
  "constraint": "12.18.3",
  "version": "12.18.3"
}
DEBUG: Resolved tag constraint(branch="renovate/react-monorepo")
{
  "image": "docker.io/renovate/node",
  "tagConstraint": "12.18.3",
  "tagVersioning": "npm",
  "tag": "12.18.3"
}
DEBUG: Fetching Docker image: docker.io/renovate/node:12.18.3(branch="renovate/react-monorepo")
DEBUG: Finished fetching Docker image(branch="renovate/react-monorepo")
DEBUG: Executing command(branch="renovate/react-monorepo")
{
  "command": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/openequella/openEQUELLA\":\"/mnt/renovate/gh/openequella/openEQUELLA\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/openequella/openEQUELLA\" docker.io/renovate/node:12.18.3 bash -l -c \"npm i -g npm && npm install --package-lock-only --ignore-scripts --no-audit\""
}
DEBUG: exec completed(branch="renovate/react-monorepo")
{
  "cmd": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/openequella/openEQUELLA\":\"/mnt/renovate/gh/openequella/openEQUELLA\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/home/ubuntu/.npmrc\":\"/home/ubuntu/.npmrc\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/openequella/openEQUELLA\" docker.io/renovate/node:12.18.3 bash -l -c \"npm i -g npm && npm install --package-lock-only --ignore-scripts --no-audit\"",
  "durationMs": 37464,
  "stdout": "/home/ubuntu/.npm-global/bin/npm -> /home/ubuntu/.npm-global/lib/node_modules/npm/bin/npm-cli.js\n/home/ubuntu/.npm-global/bin/npx -> /home/ubuntu/.npm-global/lib/node_modules/npm/bin/npx-cli.js\n+ [email protected]\nadded 434 packages from 885 contributors in 25.921s\nadded 547 packages in 5.724s\n",
  "stderr": ""
}
DEBUG: package-lock.json needs updating(branch="renovate/react-monorepo")
DEBUG: Updated 1 lock files(branch="renovate/react-monorepo")
{
  "updatedArtifacts": [
    "package-lock.json"
  ]
}
DEBUG: 2 file(s) to commit(branch="renovate/react-monorepo")
DEBUG: Committing files to branch renovate/react-monorepo(branch="renovate/react-monorepo")
INFO: Branch created(branch="renovate/react-monorepo")
{
  "commitSha": "e4037f71"
}
DEBUG: Ensuring PR(branch="renovate/react-monorepo")
DEBUG: There are 0 errors and 0 warnings(branch="renovate/react-monorepo")
DEBUG: getBranchPr(renovate/react-monorepo)(branch="renovate/react-monorepo")
DEBUG: findPr(renovate/react-monorepo, undefined, open)(branch="renovate/react-monorepo")
DEBUG: getBranchStatus(renovate/react-monorepo)(branch="renovate/react-monorepo")
DEBUG: branch status check result(branch="renovate/react-monorepo")
{
  "state": "pending",
  "statuses": []
}
DEBUG: No check runs found(branch="renovate/react-monorepo")
{
  "result": {
    "total_count": 0,
    "check_runs": []
  }
}
DEBUG: Creating PR(branch="renovate/react-monorepo")
{
  "prTitle": "Update dependency eslint-plugin-react-hooks to v4.1.2"
}
DEBUG: Reached PR limit - skipping PR creation(branch="renovate/react-monorepo")

hosted log available at https://app.renovatebot.com/dashboard#github/openequella/openEQUELLA/229207590

To Reproduce

Exceed max number of of PRs from renovate config.
Check a rate limited PR to prompt PR generation.

Additional context

@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features labels Sep 11, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 23.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants