Skip to content

Commit 4202275

Browse files
Merge pull request #314 from reown-com/fix/valtio-arrays
fix: improved state array updates in connection and router controllers
2 parents 51555a9 + d3a9604 commit 4202275

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

.changeset/purple-berries-marry.md

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
'@reown/appkit-core-react-native': patch
3+
'@reown/appkit-auth-ethers-react-native': patch
4+
'@reown/appkit-auth-wagmi-react-native': patch
5+
'@reown/appkit-coinbase-ethers-react-native': patch
6+
'@reown/appkit-coinbase-wagmi-react-native': patch
7+
'@reown/appkit-common-react-native': patch
8+
'@reown/appkit-ethers-react-native': patch
9+
'@reown/appkit-ethers5-react-native': patch
10+
'@reown/appkit-scaffold-react-native': patch
11+
'@reown/appkit-scaffold-utils-react-native': patch
12+
'@reown/appkit-siwe-react-native': patch
13+
'@reown/appkit-ui-react-native': patch
14+
'@reown/appkit-wagmi-react-native': patch
15+
'@reown/appkit-wallet-react-native': patch
16+
---
17+
18+
fix: improved state array updates in connection and router controllers

packages/core/src/controllers/ConnectorController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const ConnectorController = {
3030
},
3131

3232
addConnector(connector: Connector) {
33-
state.connectors.push(ref(connector));
33+
state.connectors = [...state.connectors, ref(connector)];
3434
},
3535

3636
getConnectors() {

packages/core/src/controllers/RouterController.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ export const RouterController = {
7272
push(view: RouterControllerState['view'], data?: RouterControllerState['data']) {
7373
if (view !== state.view) {
7474
state.view = view;
75-
state.history.push(view);
75+
state.history = [...state.history, view];
7676
state.data = data;
7777
}
7878
},
7979

8080
pushTransactionStack(action: TransactionAction) {
81-
state.transactionStack.push(action);
81+
state.transactionStack = [...state.transactionStack, action];
8282
},
8383

8484
popTransactionStack(cancel?: boolean) {

0 commit comments

Comments
 (0)