Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove expecting in the time conversion #716

Open
geekbrother opened this issue Jul 23, 2024 · 1 comment
Open

fix: remove expecting in the time conversion #716

geekbrother opened this issue Jul 23, 2024 · 1 comment
Assignees
@geekbrother
Labels
accepted The issue has been accepted into the project

Comments

@geekbrother
Copy link
Contributor

We are using expect when converting time (to EPOCH). Since this error can be thrown only when time goes back it's better to handle it properly instead of expecting.
@geekbrother geekbrother self-assigned this Jul 23, 2024
@linear Linear
Copy link

linear bot commented Jul 23, 2024

CR-490 fix: remove expecting in the time conversion

@arein arein added the accepted The issue has been accepted into the project label Jul 23, 2024
@geekbrother geekbrother mentioned this issue Jul 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arein @geekbrother