New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reflect pairing state without reload #403

Open

arein opened this issue Jan 11, 2024 · 5 comments

Assignees

Labels

good first issue

Contributor

arein commented Jan 11, 2024

Screenshot 2024-01-11 at 7 58 39 AM

Currently when a pairing is removed the wallet doesn't handle that event.
The sample wallet has to be reloaded after removing a pairing.

Acceptance criteria: https://github.com/WalletConnect/web3modal/blob/V3/apps/laboratory/tests/shared/validators/WalletValidator.ts#L13-L21 removed and tests passing

arein assigned ganchoradkov

bkrem added the good first issue label

Contributor

mabsattar commented Aug 8, 2024

@arein hi can I work on this?

Contributor

glitch-txs commented Aug 9, 2024

glitch-txs assigned mabsattar

Contributor

mabsattar commented Aug 9, 2024

@glitch-txs thank you.

Contributor

mabsattar commented Aug 14, 2024 •

edited

Loading

I'm unable to repro

Contributor

glitch-txs commented Aug 14, 2024

same, seems working normally to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment