Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bundle concat code should be consistent with Preflight concat code #1001

Closed
diamonwiggins opened this issue Feb 1, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@diamonwiggins
Copy link
Member

Describe the rationale for the suggested feature.

A recent bug was discovered in the concat code of Preflight - #998. Although there isn't a known issue in the support bundle code, we should update it for consistency.

https://github.com/replicatedhq/troubleshoot/blob/main/pkg/supportbundle/supportbundle.go#L237
https://github.com/replicatedhq/troubleshoot/blob/main/cmd/troubleshoot/cli/run.go#L101-L105

Describe the feature
Refactor the Support Bundle Concat logic to be consistent with the changes in #998

Describe alternatives you've considered

Describe alternative solutions here. Include any workarounds you've considered.

Additional context

Add additional context about the feature request. If the change is substantial, consider attaching files to the issue outlining architectural changes, data flows, file formats etc., anything that helps describe the requested change.

@yangmeilly
Copy link
Contributor

yangmeilly commented Feb 3, 2023

this issue has been annihilated by #1002

@xavpaice
Copy link
Member

#933 should resolve this as various parts of the codebase are consolidated. The main issue here is about duplicating the concat code between both preflight and support-bundle, but that duplication sits in many places in the codebase.

I'll close this since we have #1002 handling the specific issue, and #933 to tidy up in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants