highlight search during replace command #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeichestakov
approved these changes
May 9, 2024
src/vim.js
Outdated
| var regex = parseQuery(params.argString.slice(1), true, true); | ||
| if (regex) highlightSearchMatches(cm, regex); | ||
| } catch(e) { | ||
| console.log(e); |
There was a problem hiding this comment.
hmm not sure what we've been doing elsewhere but ideally we don't log too much to the user's console
nightwing
force-pushed
the
replace-highlight
branch
from
55ec9d8 to
47bdce3
Compare
nightwing
force-pushed
the
replace-highlight
branch
from
47bdce3 to
b475ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement part of changes suggested in #160 by highlighting matches during s command