Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not only .com #5

Open
kachkaev opened this issue Dec 2, 2016 · 4 comments
Open

Support not only .com #5

kachkaev opened this issue Dec 2, 2016 · 4 comments

Comments

@kachkaev
Copy link

kachkaev commented Dec 2, 2016

Following conventional-changelog/get-pkg-repo#9 (comment)

Possible solution: in index.js

// before
string = string.replace('.com:', '.com/')
// after
string = string.replace(/\.([A-Za-z]+)\:/, '.$1/');
@stevemao
Copy link
Contributor

The change seems good to me :)

@bahmutov
Copy link
Collaborator

bahmutov commented Feb 8, 2017

needs pull request and tests

@kobik
Copy link

kobik commented Jul 18, 2018

Hi @bahmutov, I've opened a PR to fix this issue.

@hutson
Copy link

hutson commented Jul 18, 2018

This was also recently reported by @kobik on semantic-release-gitlab - https://gitlab.com/hyper-expanse/open-source/semantic-release-gitlab/issues/40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants