Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #221

Open
vitaly-zdanevich opened this issue Mar 16, 2023 · 15 comments
Open

Add dark theme #221

vitaly-zdanevich opened this issue Mar 16, 2023 · 15 comments
Labels

Comments

@vitaly-zdanevich
Copy link

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@AMDmi3 AMDmi3 added the ux label Mar 17, 2023
@vitaly-zdanevich
Copy link
Author

Can I implement this?

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 25, 2024

Sure, but you've wanted to ask whether it would be accepted, and that depends on the solution. Do you have a plan? Does bootstrap support it?

@vitaly-zdanevich
Copy link
Author

I did not try with bootstrap, but I fount this - yes, looks like supported https://getbootstrap.com/docs/5.3/customize/color-modes/

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 25, 2024

That says "Added in v5.3". Repology uses bootstrap 3.

@vitaly-zdanevich
Copy link
Author

Do you want to update the Bootstrap?

@vitaly-zdanevich
Copy link
Author

...or what about to drop the Bootstrap? Why do we need it? UI is pretty simple. For the default colors/margins only?

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 26, 2024

...or what about to drop the Bootstrap?

I would definitely prefer to drop bootstrap - new versions have introduced visual (as opposed to semantic) classes like spacing utilities which is not right.

For the default colors/margins only?

No, it's used for everything so dropping it won't be trivial. The replacement should me manageable (BEM preferred), responsive stylesheet, with no regressions in accessibility and other features.

@vitaly-zdanevich
Copy link
Author

Do you know some candidates?

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 27, 2024

Which candidates?

@vitaly-zdanevich
Copy link
Author

To replace Bootstrap.

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 27, 2024

No. My plans were to use completely custom CSS.

@vitaly-zdanevich
Copy link
Author

Hm, looks like its a lot of work, right?

@AMDmi3
Copy link
Member

AMDmi3 commented Apr 28, 2024

Exactly. But maybe it can be done gradually

@vitaly-zdanevich
Copy link
Author

So, how can I start?

@AMDmi3
Copy link
Member

AMDmi3 commented Jul 1, 2024

Sorry, I cannot offer any guidance here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants