tests: additional unit tests

frontend/components/admin/rsd-contributors/apiContributors.tsx

@@ -38,7 +38,7 @@ export function useContributors({token, orderBy}:useContributorsProps) {
   const {searchFor, page, rows, setCount} = usePaginationWithSearch('Find contributor')
   const [contributors, setContributors] = useState<RsdContributor[]>([])
   const [loading, setLoading] = useState(true)
-  const [columns, setColumns] = useState(createColumns(token))
+  const [columns] = useState(createColumns(token))
 
   const loadContributors = useCallback(async () => {
     let abort = false

frontend/components/cards/CardContentFrame.tsx

@@ -3,9 +3,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function CardContentFrame({children}:{children:React.JSX.Element[]}) {
+export default function CardContentFrame({children}:{children:JSX.Element[]}) {
   return (
     <div className="h-[63%] flex flex-col p-4 relative">
       {children}

frontend/components/cards/CardImageFrame.tsx

@@ -3,9 +3,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function CardImageFrame({children}:{children:React.JSX.Element}) {
+export default function CardImageFrame({children}:{children:JSX.Element}) {
   return (
     <div className="h-[37%] flex overflow-hidden relative bg-base-100">
       {children}

frontend/components/form/ControlledTextField.tsx

@@ -6,8 +6,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
-import {useEffect, useRef} from 'react'
+import {useEffect, useRef, JSX} from 'react'
 import {Controller} from 'react-hook-form'
 import TextField, {TextFieldProps} from '@mui/material/TextField'
 import HelperTextWithCounter from './HelperTextWithCounter'
@@ -25,7 +24,7 @@ export type ControlledTextFieldOptions<T> = {
   variant?: 'outlined'|'standard'
   useNull?: boolean,
   defaultValue?: string | number | null
-  helperTextMessage?: string | React.JSX.Element
+  helperTextMessage?: string | JSX.Element
   helperTextCnt?: string
   disabled?: boolean
   muiProps?: TextFieldProps

frontend/components/form/HelperTextWithCounter.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function HelperTextWithCounter({message,count}:{message:string|undefined|React.JSX.Element,count:string}) {
+export default function HelperTextWithCounter({message,count}:{message:string|undefined|JSX.Element,count:string}) {
   return (
     <>
       <span className="mr-2">{message}</span>

frontend/components/layout/ConfirmDeleteModal.tsx

@@ -6,7 +6,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import Button from '@mui/material/Button'
 import Dialog from '@mui/material/Dialog'
 import DialogActions from '@mui/material/DialogActions'
@@ -19,7 +19,7 @@ import WarningIcon from '@mui/icons-material/Warning'
 type ConfirmDeleteModalProps = {
   open: boolean,
   title: string,
-  body: React.JSX.Element,
+  body: JSX.Element,
   onCancel: () => void,
   onDelete: () => void
 }

frontend/components/layout/ContentContainer.tsx

@@ -3,12 +3,12 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
 type ContentContainerProps = {
   element?: 'section' | 'article' | 'main' | 'div'
   className?: string
-  children: React.JSX.Element | React.JSX.Element[]
+  children: JSX.Element | JSX.Element[]
 }
 
 export default function ContentContainer(props: ContentContainerProps) {

frontend/components/layout/SortableList.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import {
   DndContext, DragEndEvent, useSensor,
   useSensors, TouchSensor, MouseSensor
@@ -23,7 +23,7 @@ export type RequiredListProps = {
 type SortableListProps<T extends RequiredListProps>={
   items:T[],
   onSorted: (items: T[]) => void
-  onRenderItem:(item:T,index:number) => React.JSX.Element
+  onRenderItem:(item:T,index:number) => JSX.Element
 }
 
 export default function SortableList<T extends RequiredListProps>({

frontend/components/mention/editMentionContext.tsx

@@ -6,7 +6,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import {createContext} from 'react'
 import {MentionItemProps} from '~/types/Mention'
 import {EditMentionAction, EditMentionState} from './editMentionReducer'
@@ -15,7 +15,7 @@ import NoMentionItems from './NoMentionItems'
 export type EditMentionSettings = {
   editModalTitle: string,
   confirmDeleteModalTitle: string,
-  noItemsComponent:()=>React.JSX.Element
+  noItemsComponent:()=>JSX.Element
 }
 
 export type EditModalProps = {

frontend/components/menu/IconBtnMenuOnAction.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import {useState} from 'react'
+import {useState, JSX} from 'react'
 import IconButton from '@mui/material/IconButton'
 import MoreVertIcon from '@mui/icons-material/MoreVert'
 import Menu from '@mui/material/Menu'
@@ -16,7 +16,7 @@ export type IconBtnMenuOption<T> = {
   type: 'divider' | 'action'
   key: string,
   label: string,
-  icon?: React.JSX.Element,
+  icon?: JSX.Element,
   action: T
   disabled?: boolean,
 }

frontend/components/organisation/metadata/Links.tsx

@@ -5,13 +5,13 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import Link from 'next/link'
 
 export type LinksProps = {
   title: string,
   url: string
-  icon: React.JSX.Element,
+  icon: JSX.Element,
 }
 
 export default function Links({links=[]}:{links:LinksProps[]}) {

frontend/components/organisation/settings/SettingsNavItems.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import InfoIcon from '@mui/icons-material/Info'
 import PersonIcon from '@mui/icons-material/Person'
 import SettingsIcon from '@mui/icons-material/Settings'
@@ -14,7 +14,7 @@ export type SettingsMenuProps = {
   id: string,
   status: string,
   label: (props?:any)=>string,
-  icon: React.JSX.Element
+  icon: JSX.Element
 }
 
 export const settingsMenu: SettingsMenuProps[] = [

frontend/components/organisation/tabs/OrganisationTabItems.tsx

@@ -3,7 +3,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import InfoIcon from '@mui/icons-material/Info'
 import TerminalIcon from '@mui/icons-material/Terminal'
 import AccountTreeIcon from '@mui/icons-material/AccountTree'
@@ -21,7 +21,7 @@ type IsVisibleProps = Partial<OrganisationForOverview> & {
 export type OrganisationTabItemProps = {
   id: string,
   label: (props:any)=>string,
-  icon: React.JSX.Element,
+  icon: JSX.Element,
   isVisible: (props: IsVisibleProps) => boolean
 }
 

frontend/components/organisation/units/ResearchUnitItem.tsx

@@ -29,8 +29,6 @@ type UnitListItemProps = {
 
 export default function UnitItem({pos,slug,name,website,logo_id,isMaintainer,onEdit}: UnitListItemProps) {
   const router = useRouter()
-  // remove query params from url (id)
-  const baseUrl = router.asPath.split('?')
   const slugs = []
   if (typeof router.query['slug'] === 'string') {
     slugs.push(router.query['slug'])

frontend/components/projects/edit/editProjectPages.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import dynamic from 'next/dynamic'
 
 import InfoIcon from '@mui/icons-material/Info'
@@ -53,8 +53,8 @@ export type EditProjectPageProps = {
   id: string,
   status: string,
   label: string,
-  icon: React.JSX.Element,
-  render: () => React.JSX.Element
+  icon: JSX.Element,
+  render: () => JSX.Element
 }
 
 export const editProjectPage: EditProjectPageProps[] = [

frontend/components/projects/overview/cards/ProjectOverviewGrid.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function ProjectOverviewGrid({children}: { children: React.JSX.Element | React.JSX.Element[] }) {
+export default function ProjectOverviewGrid({children}: { children: JSX.Element | JSX.Element[] }) {
   // console.log('ProjectOverviewGrid')
   return (
     <section

frontend/components/projects/overview/list/ProjectListItemContent.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import {getImageUrl} from '~/utils/editImage'
 import useValidateImageSrc from '~/utils/useValidateImageSrc'
 import ProjectMetrics from '../cards/ProjectMetrics'
@@ -16,7 +16,7 @@ type ProjectListItemProps = {
   image_id: string | null
   impact_cnt: number | null
   output_cnt: number | null
-  statusBanner?: React.JSX.Element
+  statusBanner?: JSX.Element
 }
 
 

frontend/components/projects/overview/list/ProjectOverviewList.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function ProjectOverviewList({children}: { children: React.JSX.Element | React.JSX.Element[]}) {
+export default function ProjectOverviewList({children}: { children: JSX.Element | JSX.Element[]}) {
   return (
     <section
       data-testid="project-overview-list"

frontend/components/software/edit/editSoftwarePages.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import dynamic from 'next/dynamic'
 
 import InfoIcon from '@mui/icons-material/Info'
@@ -56,8 +56,8 @@ export type EditSoftwarePageProps = {
   id: string
   status: string,
   label: string,
-  icon: React.JSX.Element,
-  render: () => React.JSX.Element
+  icon: JSX.Element,
+  render: () => JSX.Element
 }
 
 export const editSoftwarePage:EditSoftwarePageProps[] = [{

frontend/components/software/overview/cards/SoftwareOverviewGrid.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function SoftwareOverviewGrid({children}: { children: React.JSX.Element | React.JSX.Element[] }) {
+export default function SoftwareOverviewGrid({children}: { children: JSX.Element | JSX.Element[] }) {
   return (
     <section
       data-testid="software-overview-grid"

frontend/components/software/overview/cards/SoftwareOverviewMasonry.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function SoftwareOverviewMasonry({children}: { children: React.JSX.Element | React.JSX.Element[] }) {
+export default function SoftwareOverviewMasonry({children}: { children: JSX.Element | JSX.Element[] }) {
   return (
     <section
       data-testid="software-overview-masonry"

frontend/components/software/overview/list/OverviewListItem.tsx

@@ -3,10 +3,10 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
 type OverviewListItemProps = {
-  children: React.JSX.Element | React.JSX.Element[],
+  children: JSX.Element | JSX.Element[],
   className?: string
 }
 

frontend/components/software/overview/list/SoftwareListItemContent.tsx

@@ -3,7 +3,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import {getImageUrl} from '~/utils/editImage'
 import useValidateImageSrc from '~/utils/useValidateImageSrc'
 import SoftwareMetrics from '../cards/SoftwareMetrics'
@@ -22,7 +22,7 @@ type SoftwareOverviewListItemProps = {
   // prog_lang: string[],
   // licenses: string,
   downloads?: number
-  statusBanner?: React.JSX.Element
+  statusBanner?: JSX.Element
 }
 
 export default function SoftwareListItemContent(item:SoftwareOverviewListItemProps) {

frontend/components/software/overview/list/SoftwareOverviewList.tsx

@@ -6,9 +6,9 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 
-export default function SoftwareOverviewList({children}: { children: React.JSX.Element | React.JSX.Element[] }) {
+export default function SoftwareOverviewList({children}: { children: JSX.Element | JSX.Element[] }) {
   return (
     <section
       data-testid="software-overview-list"

frontend/components/table/EditableTable.tsx

@@ -5,7 +5,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import {SxProps, Theme} from '@mui/system'
 import Table from '@mui/material/Table'
 import TableBody from './TableBody'
@@ -29,7 +29,7 @@ export type Column<T,K extends keyof T> = {
   sx?: SxProps<Theme>
   order?: OrderProps
   patchFn?: (props: UpdateProps) => Promise<{ status: number, message: string }>
-  renderFn?: (data:T) => React.JSX.Element
+  renderFn?: (data:T) => JSX.Element
 }
 
 export type OrderByProps<T,K extends keyof T> = {

frontend/components/user/UserNavItems.tsx

@@ -8,7 +8,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-import React from 'react'
+import {JSX} from 'react'
 import dynamic from 'next/dynamic'
 
 import TerminalIcon from '@mui/icons-material/Terminal'
@@ -44,8 +44,8 @@ export type UserMenuProps = {
   id: string,
   status: string,
   label: (props:any)=>string,
-  icon: React.JSX.Element,
-  component: (props: any) => React.JSX.Element
+  icon: JSX.Element,
+  component: (props: any) => JSX.Element
   showSearch: boolean
 }