Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply user preferred layout #1003

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Apply user preferred layout #1003

merged 2 commits into from
Oct 2, 2023

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Oct 2, 2023 •
edited
Loading

Apply user preferred layout on page load

Closes #1001

Changes proposed in this pull request:

  • The user preferred layout, saved in cookie, is applied immediately if exists  
  • Next is upgraded to v13.5.3 version (last released version)

How to test:

  • make start to build app and create test data
  • navigate to software overview page, select list as layout .
  • navigate between software and project overview pages. The list layout should be applied immediately. For reference have a look at dev where the "jumping layout error" is still present.

Example list layout

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic force-pushed the 1001-appy-preferred-layout branch from f6ed89b to 58ebc1b Compare October 2, 2023 10:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dmijatovic dmijatovic merged commit 0dfd146 into main Oct 2, 2023
@dmijatovic dmijatovic deleted the 1001-appy-preferred-layout branch October 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewan-escience ewan-escience ewan-escience approved these changes

@jmaassen jmaassen Awaiting requested review from jmaassen

@ctwhome ctwhome Awaiting requested review from ctwhome

@cmeessen cmeessen Awaiting requested review from cmeessen

@fembau fembau Awaiting requested review from fembau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preferred overview layout applied with an delay
2 participants
@dmijatovic @ewan-escience