1117 disable scraping #1153
Merged
1117 disable scraping #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmijatovic
reviewed
Mar 29, 2024
| @@ -128,6 +128,17 @@ export default function AutosaveRepositoryUrl() { | |||
| } | |||
| }, [urlError, repository_url, platform.id]) | |||
|
|
|||
| async function saveScrapingDisabledReason({value}: any) { | |||
| return fetch(`/api/v1/repository_url?software=eq.${id}`, { | |||
There was a problem hiding this comment.
Can you please handle the error in try/catch and show it to using showErrorMessage. The value should not be any but a string|null, right?
ewan-escience
force-pushed
the
1117-disable-scraping
branch
from
e499d1c to
65ab5ed
Compare
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow Git scraping
Changes proposed in this pull request:
How to test:
docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0Related to #1117 (we still need to do this for package managers)
PR Checklist:
docker-compose.yml