Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store message with metadata in the error logs when saving a mention fails #1201

Merged
merged 1 commit into from
May 17, 2024
Merged

store message with metadata in the error logs when saving a mention fails #1201

merged 1 commit into from
May 17, 2024

Conversation

ewan-escience
Copy link
Collaborator

Store the DOI, external ID and source in the error logs when a mention couldn't be saved in the database for whatever reason.

@ewan-escience ewan-escience self-assigned this May 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed for 'scrapers'

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

jmaassen
jmaassen approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ewan-escience ewan-escience merged commit 6d9db92 into main May 17, 2024
1 of 2 checks passed
@ewan-escience ewan-escience deleted the better-mention-error-message branch May 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaassen jmaassen jmaassen approved these changes

Assignees

@ewan-escience ewan-escience

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewan-escience @jmaassen