Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repository urls ending with .git #1245

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

cmeessen
Copy link
Contributor

@cmeessen cmeessen commented Jul 4, 2024

Fixes #1244

Changes proposed in this pull request:

  • scrapers recognise repository urls that end with .git and scrape them
  • adds a sentence to the UI stating which URLs are supported
  • update user documentation
  • adds tests for the scrapers (disabled)
  • rename GithubScaperTestIT to GithubScraperTestIT
  • fix bug where scraping_disabled_reason text field shows number of characters of repository_url

How to test:

  • docker compose down --volumes && docker compose build --parallel && docker compose up
    
  • create four software entries with the following repository URLs (or those of you choice) and set them visible:
    • https://github.com/research-software-directory/RSD-as-a-service.git
    • https://github.com/research-software-directory/RSD-as-a-service
    • https://codebase.helmholtz.cloud/research-software-directory/RSD-as-a-service.git
    • https://codebase.helmholtz.cloud/research-software-directory/RSD-as-a-service
  • wait for the scrapers to run or force them with:
    docker compose run scrapers /opt/java/openjdk/bin/java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.git.MainCommits
    
  • verify that the software entries display the scraped information

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@cmeessen cmeessen self-assigned this Jul 4, 2024
Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change requested, see the comment. Otherwise, nice work!

Copy link

sonarcloud bot commented Jul 5, 2024

Copy link

sonarcloud bot commented Jul 5, 2024

@cmeessen cmeessen merged commit dbaec1d into main Jul 8, 2024
5 checks passed
@cmeessen cmeessen deleted the 1244-repository-url branch September 16, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository URL field does not support actual repository URL
2 participants