Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save ROR data to RSD and use it #1337

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Save ROR data to RSD and use it #1337

merged 2 commits into from
Nov 7, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Nov 4, 2024

Save ROR data in RSD

Closes #1333

Changes proposed in this pull request:

  • ROR scraper updates organisation data
  • We save more organisation data to RSD (city, wikipedia_url, lat,lon etc.) and use these instead of making requests to ROR api.

How to test:

  • it is better to use empty RSD for this test, so use docker compose build && docker compose up
  • login to RSD
  • create one software entry.
  • add eScienceCenter organisation from ROR to software
  • navigate to organisation and confirm that ROR data is visible
  • create one project entry
  • add Microsoft organisation from ROR to project
  • navigate to organisation and confirm that ROR data is visible
  • now add eScienceCenter organisation to project. This should work too, but now the organisation is added from RSD
  • add third organisation manually: search for organisation like "New organisation I want to add". The option "Add..." should appear so you can add organisation manually.
  • navigate to this new organisation. This organisation should not have ROR information (ROR link, type etc).
  • examine console logs and confirm that ROR scraper is running from time to time :-).

Example ROR organisation page

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic force-pushed the 1333-expand-ror-scraper branch 2 times, most recently from 5879ef8 to aee31e5 Compare November 4, 2024 16:27
@dmijatovic dmijatovic marked this pull request as ready for review November 4, 2024 16:43
Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

sonarcloud bot commented Nov 5, 2024

@dmijatovic dmijatovic merged commit 3b720f7 into main Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand ROR scraper and drop ad hoc ROR requests
2 participants