-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add slug for software, projects and news #1340
Conversation
c23b859
to
3600343
Compare
12cdd0d
to
c9c7def
Compare
Works well, but I seem to have found one small bug? Sometimes when I add software with a duplicate slug, the warning doesn't appear and the loader keeps on turning. No error is shown: As soon as I replaced the name with an unused one, then followed by the used one, the error is shown correctly. I can reproduce this with both software and projects:
|
bdc7ae4
to
669ab6b
Compare
@jmaassen Well spotted! I have fixed the error. Can you test again, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works mostly well, but I found one small issue.
When editing the slug on an add page, if I delete the slug character by character, fast enough to not lose the spinner, the spinner will run forever when the slug becomes empty.
In the future, it would be nice if the /add
path would show a page with items you can add instead of a 404 page.
669ab6b
to
936674c
Compare
936674c
to
32c3fdf
Compare
|
@ewan-escience Great! I fixed your remark. Can you validate, please? |
User cannot create software or project using "add" slug
Closes #1338
Related to #525
Changes proposed in this pull request:
add
routeUNRELATED
: Adapted width of custom pages to 1024px for easier reading.How to test:
make start
to build and create test dataExample cookies page layout
PR Checklist:
docker-compose.yml