Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search for C++ #1347

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: search for C++ #1347

merged 1 commit into from
Nov 18, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Nov 15, 2024

Fix search on software, project and organisation page

Changes proposed in this pull request:

  • encode search param to allow use of "reserved" characters like +, { and others  

How to test:

  • make start to build and generate test data.
  • try searching for C++, C%% on software overview page. The url param should be encoded and C++ should be visible in search box.
  • try searching for C++ on project overview page. The url param should be encoded and C++ should be visible in search box.
  • try searching for C++ on organisation page. The url param should be encoded and C++ should be visible in search box.

Example C++ search for software

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic changed the title fix: encode search term to support 'reserved' characters like + and others fix: search for C++ Nov 15, 2024
Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works mostly well, but not when you search for a percent sign (%). Maybe it works when you also quote "" the search term (before encoding)...

Copy link

sonarcloud bot commented Nov 15, 2024

@dmijatovic dmijatovic merged commit 9f4f4c7 into main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants