-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSD v2 release #787
RSD v2 release #787
Conversation
dfc38e4
to
79893e0
Compare
79893e0
to
8766aee
Compare
ba2ebd6
to
afeeb64
Compare
6384d30
to
8451a08
Compare
ba14e5d
to
ebe5756
Compare
b2df944
to
8bfa359
Compare
1a367af
to
cc007e0
Compare
8d16584
to
3609da4
Compare
b20cffb
to
c2735ed
Compare
03234c9
to
3168ac3
Compare
3168ac3
to
d08e1c4
Compare
87a81fd
to
d62b4bc
Compare
d62b4bc
to
e345607
Compare
SonarCloud Quality Gate failed. 4 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
8927b2b
to
b23eec9
Compare
[authentication] Kudos, SonarCloud Quality Gate passed! |
[scrapers] Kudos, SonarCloud Quality Gate passed! |
9b37a12
to
d338619
Compare
…t card position and the image resizing problem in the card.
…e audit feedback.
…ts for future test purposes and use theme colors.
…do not blow up small images)
…order on organisation page.
d0d8461
to
29cfb7d
Compare
@cmeessen @fembau @jmaassen @ewan-escience @ctwhome I rebased this PR onto the last release of v1.27.0. Can you test this version of PR as the first release candidate of v2.0.0, please? I would like to merge this PR into main as soon as possible and set it on our dev server for further testing. Before official release we want to invite some "power users" to have a look at this version before official release. I expect official release of v2 to be ~1-2 weeks from now if no major errors are discovered. |
[rsd-database] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[rsd-frontend] SonarCloud Quality Gate failed. 0 Bugs 54.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@cmeessen Can you perform final test of this PR on your side. NOTE! We made one minor DB update on rpc in 100-xxx script. -- programming language filter for software
-- used by software_overview func
CREATE FUNCTION prog_lang_filter_for_software() RETURNS TABLE (
software UUID,
prog_lang TEXT[]
) LANGUAGE plpgsql STABLE AS
$$
BEGIN
RETURN QUERY
SELECT
repository_url.software,
(SELECT
ARRAY_AGG(p_lang ORDER BY repository_url.languages -> p_lang DESC)
FROM
JSONB_OBJECT_KEYS(repository_url.languages) p_lang
) AS "prog_lang"
FROM
repository_url
;
END
$$; If you have any questions let me know :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, I am looking forward to seeing this live!
RSD 2 release
This PR collects all features to be included in v2 release.
include BREAKING CHANGES in the last commit. - DONE in #927
Closes #655
Closes #789
Closes #792
Closes #803
Closes #806
Closes #823
Closes #824
Closes #838
Closes #888
Closes #896
Closes #916
Closes #913
Closes #924
Closes #922
Closes #932
Closes #933
Closes #934
Closes #935
Closes #936
Closes #937
Closes #938
Closes #955
Closes #976
Closes #979
Closes #980
Closes #982
Changes proposed in this pull request:
Conclusion
The load tests show that RSD v2 server capacity dropped significantly compared to v1. The additional features introduced in v2 require more resources. However, the current capacity of RSD hardware is sufficient to offer additional v2 features under the
current
traffic. After implementing few optimizations the page load of v2 is comparable to v1 when analysed using Lighthouse.RSD capacity difference RSD-v1.26.0 vs RSD-v2.0.0
In the K6 load test below, performed on the same hardware, we see that achieving same througoutput (100 users) with v2 is not possible. However, our current hardware CPU capacity on RSD VM seem sufficient. We utilize <10% of the hardware CPU capacity on average day. Based on this test results I expect hardware's CPU utilization to increase to ~30%. For the partners is it important to check their current hardware utilization and take into a count required increase in capacity when upgrading to v2. The data traffic is estimated to be ~150% of v1. Partners are adviced to test v2 performance before commiting to upgrade.
Performance improvements
Based on performed load tests on pages and the api we identified few improvement points. These are implemented in #973. Although the performance of specific api calls is improved significantly the total server capacity remains significantly lower compared to v1 as shown in the image below.
Lighthouse audit improvements
In addition to api improvements we implemented lighthouse audit suggestions. This lead to significant improvement in the lighthouse scores especially on software overview page. The project overview page, for example, have slightly better score in v2 than in v1 (see image).
Software overview
Project overview
How to test:
make start
to build appPR Checklist:
docker-compose.yml