Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

933 show different into about project period based on project state #962

Closed
wants to merge 1 commit into from

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Aug 10, 2023

Project state and the period presentation improvements

Closes #933

Changes proposed in this pull request:

  • Based on project period we deduct project status. We classify project status into following categories:
    • Finished: when project end date is in the past (< now())
    • In progress: when project start date is in the past and end date in the future
    • Pending: when project start date and end date are in the future
    • Waiting to start: in all other cases (missing just start date or missing start date and end date and any other situations - it is final ELSE clause)

NOTE! The same project status values should be applied to status filter proposed in #934.

How to test:

  • make start to build solution and generate random data
  • navigate to project overview and confirm that:
    • Finished projects show only dates / period
    • In progress and pending projects show dates and the progress bar
    • Projects with missing start date or end date have message 'Waiting to start'
  • navigate to project overview of an organisation and confirm the same approach on project card

Example project overview cards

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

[authentication] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

[scrapers] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

[rsd-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

[rsd-database] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
94.4% 94.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dmijatovic dmijatovic changed the title feat: show different into about project period based on project state 933 show different into about project period based on project state Aug 10, 2023
@dmijatovic
Copy link
Contributor Author

Closing this PR in favor of #964

@dmijatovic dmijatovic closed this Aug 14, 2023
@dmijatovic dmijatovic deleted the 933-status-bar branch September 4, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant