New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse: add arial labels to admin buttons. #977

Merged

dmijatovic merged 1 commit into rsd-v2-release from 976-lighthouse-audit

Sep 4, 2023

Contributor

dmijatovic commented Sep 4, 2023

Lightouse improvement suggestions for organisation page

Closes #976

Changes proposed in this pull request:

Add aria labels to admin buttons on organisation page

How to test:

make start to build complete solution
login as rsd-admin role. If you use same .env as mine you can login as professor3
navigate to organisation page as admin
run Lighthouse audit on the page. The score should be improved and there will be no messages about buttons missing accessible name (see image bellow).
Note! the score will probably not be that high on your local machine because ssl + http2 is not enabled at localhost.

Audit improvement

PR Checklist:

Increase version numbers in docker-compose.yml
Link to a GitHub issue
Update documentation
Tests


          lighthouse: add arial labels to admin buttons.

9dcc5a1

dmijatovic requested review from jmaassen, cmeessen, ewan-escience and fembau

September 4, 2023 10:59

sonarcloud bot commented Sep 4, 2023

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

dmijatovic merged commit a07ed9e into rsd-v2-release

4 checks passed

dmijatovic deleted the 976-lighthouse-audit branch

September 28, 2023 07:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet