Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent blurry logo image in the organisation card #988

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: prevent blurry logo image in the organisation card #988

merged 1 commit into from
Sep 19, 2023

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Sep 19, 2023 •
edited
Loading

Organisation card logo/image scaling

Changes proposed in this pull request:

  • Prevent enlarging of organisation images/logo's with very small dimensions. See examples from live RSD on dev
  • The similar scaling is applied to software card logo's previously. The look of "larger" images in the card remains unchanged.

How to test:

  • make start to build
  • login as rsd admin
  • navigate to organisations overview. the logos should look nice.
  • change the organisation logo to a very small image. The logo in the card should be sharp but small, not large and blurry (see example).

Example scaling change

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ewan-escience
ewan-escience approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, but in the organisation page itself the logo still gets blurry, maybe you can fix that as well.

@dmijatovic dmijatovic merged commit 26273ad into main Sep 19, 2023
4 checks passed
@dmijatovic dmijatovic deleted the organisation-card-image branch September 28, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewan-escience ewan-escience ewan-escience approved these changes

@jmaassen jmaassen Awaiting requested review from jmaassen

@ctwhome ctwhome Awaiting requested review from ctwhome

@cmeessen cmeessen Awaiting requested review from cmeessen

@fembau fembau Awaiting requested review from fembau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmijatovic @ewan-escience