Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software card without image #997

Closed
wants to merge 1 commit into from

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Sep 28, 2023

Create software card without image/image placeholder

Related to #996

Changes proposed in this pull request:

  • Create software card that does not show image or image placeholder  
  • Note! The organisation software card requires image placeholder space to show ... menu and the statuses (not published, pinned etc)

How to test:

  • make start to build app and create test data
  • navigate to software overview page and confirm that cards without image/logo are shown
  • navigate to organisation and confirm that cards without image/logo are shown
  • login as rsd_admin, navigate to organisation and confirm that you can pin, unpin, block and unblock software

Software cards without image/image placeholder

image

Organisation software cards without image/image placeholder

image

Organisation software cards for maintainers

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[rsd-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.5% 88.5% Coverage
33.0% 33.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dmijatovic dmijatovic changed the title Software card without image placehoder Software card without image Sep 28, 2023
@jmaassen
Copy link
Member

After further discussion with Christian and Maaike we decide to release with this view after all. It works well on the Helmholtz instance, so we believe that it should also work for eScience if we improve the data quality.

@dmijatovic dmijatovic closed this Oct 2, 2023
@dmijatovic dmijatovic deleted the software-card-without-image branch October 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants