Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-email render not working on Safari due to 'ReadableByteStreamController not defined' #1732

Open
Ildrid opened this issue Oct 14, 2024 · 2 comments

Comments

@Ildrid
Copy link

Ildrid commented Oct 14, 2024

Describe the Bug

The render function does not return neither data or error when using Safari/mac. Console error states 'ReadableByteStreamController not defined'.

Solved this in our project by implementing "web-streams-polyfill/polyfill".

Related to ReadableByteStreamController not being compatible with Safari:
https://developer.mozilla.org/en-US/docs/Web/API/ReadableByteStreamController

Which package is affected (leave empty if unsure)

@react-email/render

Link to the code that reproduces this issue

Most likely a problem in any project.

To Reproduce

Use Safari (or chrome/safari on iPad) when trying to render the e-mail.

Expected Behavior

Render to work as intended, or at least break and return error.

What's your node version? (if relevant)

"@react-email/render": "1.0.1"

@naaa760
Copy link

naaa760 commented Oct 24, 2024

Hello @Ildrid :)
I would like to work on this issue!

@gabrielmfern
Copy link
Collaborator

@naaa760 Feel free to open a PR. I'd advise you go through this for dev workflow.

To fix this kind of issue, we probably are going to have to include some sort of polyfill in the render function itself. So part of looking into fixing this is researching and trying to understand if we should really include a polyfill, or if it would be better to advise users to include it themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants