Skip to content

Facade patch for individual claimRewards #4118

Facade patch for individual claimRewards

Facade patch for individual claimRewards #4118

Triggered via pull request December 3, 2024 21:54
@tbrenttbrent
synchronize #1231
facade-patch
Status Failure
Total duration 1h 7m 31s
Artifacts

tests.yml

on: pull_request
Deployment Scripts
8m 45s
Deployment Scripts
Lint Checks
13m 37s
Lint Checks
Plugin Unit Tests
10m 0s
Plugin Unit Tests
Plugin Integration Tests (Mainnet) - 1/3
1h 7m
Plugin Integration Tests (Mainnet) - 1/3
Plugin Integration Tests (Mainnet) - 2/3
26m 13s
Plugin Integration Tests (Mainnet) - 2/3
Plugin Integration Tests (Mainnet) - 3/3
36m 23s
Plugin Integration Tests (Mainnet) - 3/3
Plugin Integration Tests (Base)
20m 15s
Plugin Integration Tests (Base)
Plugin Integration Tests (Arbitrum)
21m 44s
Plugin Integration Tests (Arbitrum)
P0 tests
17m 54s
P0 tests
P1 Tests
18m 48s
P1 Tests
Scenario Tests
8m 16s
Scenario Tests
Extreme Tests
50m 22s
Extreme Tests
Integration Tests
10m 50s
Integration Tests
Monitor Tests (Mainnet)
3m 22s
Monitor Tests (Mainnet)
Registry Tests
2m 6s
Registry Tests
Fit to window
Zoom out
Zoom in

Annotations

1 error and 25 warnings
Plugin Integration Tests (Base)
Process completed with exit code 2.
Registry Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Monitor Tests (Mainnet)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Scenario Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Deployment Scripts
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Unit Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Integration Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint Checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint Checks: contracts/facade/Facade.sol#L32
When fallback is not payable you will not be able to receive ether
Lint Checks: contracts/facade/Facade.sol#L32
Fallback function must be simple
Lint Checks: contracts/facade/Facade.sol#L37
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
Lint Checks: contracts/p0/Deployer.sol#L178
Code contains empty blocks
Lint Checks: contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
Lint Checks: contracts/p1/Main.sol#L158
Avoid to use low level calls
P0 tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
P1 Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Integration Tests (Base)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Integration Tests (Arbitrum)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Integration Tests (Mainnet) - 2/3
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Integration Tests (Mainnet) - 3/3
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Extreme Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Plugin Integration Tests (Mainnet) - 1/3
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636