nars - snars - collateral plugin #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmckelvy1
requested changes
Oct 8, 2024
| @@ -1003,6 +1004,32 @@ export default function fn<X extends CollateralFixtureContext>( | |||
| targetUnitOracle.address, | |||
| ORACLE_TIMEOUT | |||
| ) | |||
| } else if (target == ethers.utils.formatBytes32String('ARS')) { | |||
| // ARS | |||
There was a problem hiding this comment.
i think we want to throw an error if not targetting Base, right? seems to be the only chain on which nARS is deployed
There was a problem hiding this comment.
why was this removed? my point was that we just need to check if we're running the tests against base
test/plugins/individual-collateral/num/SNARSFiatCollateral.test.ts
Outdated
Show resolved
Hide resolved
pmckelvy1
requested changes
Oct 21, 2024
pmckelvy1
requested changes
Nov 13, 2024
|
|
||
| In this particular case we're incorporating through this plugin 2 nTokens. | ||
|
|
||
| - `nARS` is a stablecoin pegged to the `Argentine Peso (ARS)`. |
There was a problem hiding this comment.
please include a note on the oracle used here. iirc you run the oracle and update it rather frequently. detail the % deviation and timeout thresholds (assuming they are in your documentation, but would like to have it legible directly in this repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens Description:
NARS: Token peged to ARS (Argentinean Peso)
Token Address: 0x5e40f26E89213660514c51Fb61b2d357DBf63C85 (Base)
Valuation: Chianlink Oracle 0xC3a426Ef79fd60A4cA785FC04a2C3cB09d2FEeae
SNARS: Yield Bearing Token nomitaned in NARS
Token Address: 0xC1F4C75e8925A67BE4F35D6b1c044B5ea8849a58 (Base)
Valuation: (amount * convertToAsset(Function in the SNARS token Address)) / NARS Oracle Price