-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oeth L2 base plugin #1226
base: 4.0.0
Are you sure you want to change the base?
Oeth L2 base plugin #1226
Conversation
Oeth L2 base plugin - Adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok, had to do some tweaks to get tests running.. Have a few questions on a few things in the plugin code. Also we definitely want a README
like we have for other plugins (in the plugin/assets/origin
folder)
test/plugins/individual-collateral/origin/OETHCollateralL2Base.test.ts
Outdated
Show resolved
Hide resolved
test/plugins/individual-collateral/origin/OETHCollateralL2Base.test.ts
Outdated
Show resolved
Hide resolved
test seem to be failing due to something about the chain not resetting correctly between tests, I think? not sure why else the addition a new testfile would have broken the old stable collateral |
Fixed tests, was missing a change we did in another PR. |
workaround for github secrets stuff from #1223