Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oeth L2 base plugin #1226

Open
wants to merge 22 commits into
base: 4.0.0
Choose a base branch
from
Open

Oeth L2 base plugin #1226

wants to merge 22 commits into from

Conversation

tbrent
Copy link
Collaborator

@tbrent tbrent commented Nov 6, 2024

workaround for github secrets stuff from #1223

@tbrent tbrent mentioned this pull request Nov 6, 2024
@tbrent tbrent requested a review from julianmrodri November 27, 2024 00:39
Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks ok, had to do some tweaks to get tests running.. Have a few questions on a few things in the plugin code. Also we definitely want a README like we have for other plugins (in the plugin/assets/origin folder)

@tbrent
Copy link
Collaborator Author

tbrent commented Dec 2, 2024

test seem to be failing due to something about the chain not resetting correctly between tests, I think? not sure why else the addition a new testfile would have broken the old stable collateral

@julianmrodri
Copy link
Contributor

Fixed tests, was missing a change we did in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants