Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow filing of Nil return for GSTR-1 #2906

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

feat: allow filing of Nil return for GSTR-1 #2906

wants to merge 6 commits into from
+52 −9

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Dec 26, 2024 •
edited by huly-for-github bot
Loading

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (5f227b2) to head (267bba3).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...st_india/doctype/gst_return_log/generate_gstr_1.py 30.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2906      +/-   ##
===========================================
- Coverage    60.15%   60.07%   -0.08%     
===========================================
  Files          122      122              
  Lines        12063    12087      +24     
===========================================
+ Hits          7256     7261       +5     
- Misses        4807     4826      +19
Files with missing lines Coverage Δ
...mpliance/gst_india/api_classes/taxpayer_returns.py 54.76% <100.00%> (ø)
...st_india/doctype/gst_return_log/generate_gstr_1.py 14.78% <30.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

@ljain112 ljain112 self-assigned this Dec 26, 2024
@ljain112 ljain112 added the p1 label Dec 26, 2024
@vorasmit vorasmit marked this pull request as draft January 8, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljain112 ljain112 ljain112 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ljain112 ljain112

Labels
p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filing of Nil return for GSTR-1
2 participants
@Sanket322 @ljain112