Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata types to restate_types #2574

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muhamadazmy
Copy link
Contributor

Move metadata types to restate_types

Summary:
Moving all common metadata types that is used over grpc
to their own module under restate_types. This will make it
possible to reuse them for other grpc service (like NodeCtlSvc)

@muhamadazmy muhamadazmy force-pushed the pr2574 branch 2 times, most recently from b9e80a1 to 80bc1a6 Compare January 29, 2025 10:25
@muhamadazmy muhamadazmy marked this pull request as ready for review January 29, 2025 10:26
@muhamadazmy
Copy link
Contributor Author

@tillrohrmann this work was done as a preparation for NodeCtlSvc work that should follow. This way we can add some metadata related functionality via the node svc which is required by the restatectl command to operate seamlessly. Please take a look when possible before new merge conflicts are introduced. Thank you

Summary:
Moving all common metadata types that is used over grpc
to their own module under restate_types. This will make it
possible to reuse them for other grpc service (like NodeCtlSvc)
@muhamadazmy muhamadazmy marked this pull request as draft January 30, 2025 08:30
@muhamadazmy muhamadazmy removed the request for review from tillrohrmann January 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant