Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with maturian shows new warring #35

Open
igalshilman opened this issue Feb 5, 2025 · 2 comments
Open

Building with maturian shows new warring #35

igalshilman opened this issue Feb 5, 2025 · 2 comments

Comments

@igalshilman
Copy link
Contributor

igalshilman commented Feb 5, 2025

running maturin dev -E ... emits warning of type:

warning: unexpected `cfg` condition value: `gil-refs`
   --> src/lib.rs:188:1
    |
188 | / create_exception!(
189 | |     restate_sdk_python_core,
190 | |     VMException,
191 | |     pyo3::exceptions::PyException,
192 | |     "Restate VM exception."
193 | | );
    | |_^
    |
    = note: no expected values for `feature`
    = help: consider adding `gil-refs` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default
    = note: this warning originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `create_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

``
@slinkydeveloper
Copy link
Collaborator

Looked at this, and it seems the last py03 version fixes it. I think we can upgrade safely, py03 last version drops support for Python 3.7 and 3.8, but our wheel is already declaring minimum python version 3.11

@slinkydeveloper
Copy link
Collaborator

Looked a bit into bumping to pyo3 latest version, there's few things to check out here https://pyo3.rs/v0.23.0/migration#from-022-to-023. Will do that when adapting to protocol v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants