Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jackson 의존성 제거 #306

Merged
merged 2 commits into from
Nov 29, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: jackson 의존성 제거
Juhongseok committed Nov 28, 2023
commit 96da1eba95f4d66aced137cdb167ab4cf1266a59
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.career.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -15,7 +14,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("careers")
public class CareerCreateRequest extends ComponentCreateRequest {

private String companyName;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.certification.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -10,7 +9,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("certifications")
public class CertificationCreateRequest extends ComponentCreateRequest {

private String certificationTitle;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -11,7 +10,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("activities")
public class ActivityCreateRequest extends ComponentCreateRequest {

private String activityName;
Original file line number Diff line number Diff line change
@@ -1,25 +1,7 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
import org.devcourse.resumeme.business.resume.controller.career.dto.CareerCreateRequest;
import org.devcourse.resumeme.business.resume.controller.certification.dto.CertificationCreateRequest;
import org.devcourse.resumeme.business.resume.service.v2.ComponentDomain;

@JsonTypeInfo(
use = JsonTypeInfo.Id.NAME,
include = JsonTypeInfo.As.PROPERTY,
property = "type"
)
@JsonSubTypes(value = {
@JsonSubTypes.Type(value = ActivityCreateRequest.class, name = "activities"),
@JsonSubTypes.Type(value = CareerCreateRequest.class, name = "careers"),
@JsonSubTypes.Type(value = CertificationCreateRequest.class, name = "certifications"),
@JsonSubTypes.Type(value = ForeignLanguageCreateRequest.class, name = "foreignLanguages"),
@JsonSubTypes.Type(value = ProjectCreateRequest.class, name = "projects"),
@JsonSubTypes.Type(value = TrainingCreateRequest.class, name = "trainings"),
@JsonSubTypes.Type(value = ResumeLinkRequest.class, name = "links")
})
public abstract class ComponentCreateRequest {

public abstract ComponentDomain toVo();
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -9,7 +8,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("foreignLanguages")
public class ForeignLanguageCreateRequest extends ComponentCreateRequest {

private String language;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -11,7 +10,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("projects")
public class ProjectCreateRequest extends ComponentCreateRequest {

private String projectName;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -10,7 +9,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("links")
public class ResumeLinkRequest extends ComponentCreateRequest {

private String linkType;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.devcourse.resumeme.business.resume.controller.dto;

import com.fasterxml.jackson.annotation.JsonTypeName;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@@ -11,7 +10,6 @@

@Getter @Setter
@NoArgsConstructor
@JsonTypeName("trainings")
public class TrainingCreateRequest extends ComponentCreateRequest {

private String organization;