Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Language Comparison Tracker 1.1.0 #456

Open
64 tasks
dsturgell opened this issue Jun 29, 2020 · 0 comments
Open
64 tasks

Language Comparison Tracker 1.1.0 #456

dsturgell opened this issue Jun 29, 2020 · 0 comments
Assignees
Labels
Helium Helium Issues UserStory User Story
Milestone

Comments

@dsturgell
Copy link
Contributor

dsturgell commented Jun 29, 2020

Key Vault Secrets

Retrieved and Used from Key Vault

  • AcrPassword
  • AcrUserId
  • AppInsightsKey
  • CosmosCollection
  • CosmosDatabase
  • CosmosKey
  • CosmosUrl

Expected Behaviours

  • Runs successfully without App Insights Key secret set
  • Fails as expected without Cosmos secrets provided
  • Key Rotation Handling Implemented

Cosmos DB

  • One Collection (movies)
  • getAllGenres query uses "VALUE" to get array of string
  • Use prepared SQL queries

Support Command Line & Environment Variables

  • KEYVAULT_NAME (env var)
  • --keyvault-name (cmd line)
  • AUTH_TYPE (env var)
  • --auth-type (cmd line)
  • LOG_LEVEL (env var)
  • --log-level (cmd line)
  • --dry-run (cmd line)
  • --help (cmd line)
  • --version (C#)

MSI to access Key Vault

  • App Services
  • CLI Cached Credentials
  • Visual Studio Cached Credentials (not supported other than Windows)
  • MSI required/enforced in production

Logging Behavior

  • Logging only Exceptions/Failures by default

Observability/Testing

  • Unit Tests
  • Metrics reporting to dashboard
  • E2E integration testing running
  • Alerts configured (Infra not apps)

Versioning

  • Version is set to 1.0.[Milestone]+MMdd.HHmm (UTC)

Parameter Validation (update API Spec to this in .md file)

  • q
  • pageNumber
  • pageSize
  • genre
  • year
  • rating
  • actorId

API Endpoints

  • /api/movies?q={}&genre={}&year={}&rating={}&actorId={}&pageNumber={}&pageSize={}
  • /api/movies/{movieId}
  • /api/actors?q={}&pageNumber={}&pageSize={}
  • /api/actors/{actorId}
  • /api/featured/movie
  • /api/genres

**Middleware **

  • /robots*.txt
  • /version

Healthz

  • /healthz
  • /healthz/ietf

CI-CD/Build/Deployment

  • Includes Dockerfile at root
  • CI-CD is set up in repo
  • CI-CD includes e2e testing
  • Can be deployed with App Services
  • Can be deployed with AKS (using Pod Identity)
  • PRs code changes are deployed to e2e testing environment

Linting

  • Linter being used (tslint)
  • No lint errors
  • Linter running in Dockerfile, fails to build if errors

Documentation

  • Developer docs
  • Supports Codespaces and documents proper uses
  • Repo contains use of .devcontainer
  • Readme specific to language
  • Readme consistent with latest changes (design review 6/9)
  • Use shared Swagger Docs
@dsturgell dsturgell added Helium Helium Issues UserStory User Story labels Jun 29, 2020
@dsturgell dsturgell added this to Triage in Helium via automation Jun 29, 2020
@dsturgell dsturgell removed this from Triage in Helium Jun 29, 2020
@dsturgell dsturgell added this to the M8 milestone Jun 29, 2020
@dsturgell dsturgell changed the title Language Comparison Tracker Language Comparison Tracker 1.1.0 Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Helium Helium Issues UserStory User Story
Projects
None yet
Development

No branches or pull requests

2 participants