Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEDIA_KEY: [object Event] #6

Open
programmhenry opened this issue Apr 10, 2020 · 15 comments
Open

MEDIA_KEY: [object Event] #6

programmhenry opened this issue Apr 10, 2020 · 15 comments

Comments

@programmhenry
Copy link

After each song this message appears twice.

@revblaze
Copy link
Owner

Hey @programmhenry, how is the message presenting itself? Is it an alert or is it appearing in the console, etc.? I'll check it out, send a screenshot if possible – would be super helpful!

@programmhenry
Copy link
Author

Screenshot 2020-04-14 at 12 46 24
Screenshot 2020-04-14 at 12 46 29

@programmhenry
Copy link
Author

programmhenry commented Apr 14, 2020

When I click on a song it starts and these two alters appear and every time a new song starts

@revblaze
Copy link
Owner

revblaze commented Apr 15, 2020

Super strange, I haven't come across this one yet. Is it specific to certain albums or does it appear with every song? Try out the build I just pushed and let me know if this continues to happen. I cleaned up a lot of the JavaScript code in the latest release.

Do any errors or bugs come with that alert? Or is the alert simply presenting itself – twice – upon every new song?

Regardless, sounds like a super annoying bug. If this continues to occur, I'll push out a hot fix that silences those alerts (forces them not to appear) until I figure out what's going on.

@revblaze revblaze reopened this Apr 15, 2020
@revblaze
Copy link
Owner

EDIT: Oops, didn't mean to close this issue.

@programmhenry
Copy link
Author

These two messages appear with each song. Since you are using WebKit I have tried something: I went to beta.music.apple.com and started a song there and see: Also there this error message appears every time.

@revblaze
Copy link
Owner

So the source – Apple Music Web Player Beta – is presenting the same alerts? In the meantime, I'll setup a listener for alerts that contain the title MEDIA_KEY: [object Event] and disable them from presenting themselves.

It's hard to debug this issue without being able to replicate it myself. Again, in the meantime, I'll create a workaround by mimicking the alerts that you are receiving and have them silenced upon prompt. You shouldn't notice it after that. Will update this issue when I get time in-between studying.

Let me know if you have any new developments on your end!

@revblaze
Copy link
Owner

UPDATE: Apple just took their Web Player out of beta and have seemed to fix a number of bugs. Clear your browser cache – maybe also restart your machine – and let me know if this issue isn't fixed.

I'm currently in the process of migrating Ultra for Music over to the new out-of-beta module. Will have to do some major restructuring.

@programmhenry
Copy link
Author

I cleared my cache and restarted my machine. The Problem stays.

@programmhenry
Copy link
Author

I tested the music.apple.com Website in Chrome and there isn´t the Problem

@programmhenry
Copy link
Author

Screenshot 2020-04-21 at 21 08 50
This is what I get from the console in Safari

@revblaze
Copy link
Owner

revblaze commented May 7, 2020

Funny, Apple is building their web player with dedicated support for Safari. 3rd-party browsers are all using the industry web standards (disabled -webkit-blur effects, etc). Some of their experimental features must still be problematic with WebKit. Will look into the differences between the two (Safari and 3rd-party) and see if I can create a soft medium between the two.

@programmhenry
Copy link
Author

Could you fix the problem?

@grumero
Copy link

grumero commented Jun 23, 2020

You are on a Mac or Hackintosh?

@revblaze
Copy link
Owner

revblaze commented Jun 9, 2021

I've managed to silence the issue as a temporary workaround with the current build I'm developing of the new release, as it appears the error doesn't actually affect functionality. Although I haven't run into the issue since, I do remember that it forced the playback to either stop or restart entirely. I'll attempt to debug the issue. In the meantime, I've added additional checks to ensure playback will not be interrupted when this alert is silenced. I will be releasing the code should shortly. 🍻

The addition of TypeSwift in the coming release will allow me to debug and fix these issues in a more timely manner (the next time it occurs). See issue #11 for additional information (to be updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants