Add flag to send email signups to staging instead of prod #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This is a no-op for the moment; Zuplo-side change to read the flag and act on it is upcoming. ## Test Plan Watch network traffic in web inspector. With the flag set, submit an email and make sure the flag is present and set to true in the payload. Without the flag set, submit an email and make sure the flag is not in the payload at all.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hblumberg
approved these changes
Dec 3, 2024
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a no-op for the moment; Zuplo-side change to read the flag and
act on it is upcoming.
Test Plan
Watch network traffic in web inspector.
With the flag set, submit an email and make sure the flag is present
and set to true in the payload.
Without the flag set, submit an email and make sure the flag is not
in the payload at all.