Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with weekend bug #11

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Deal with weekend bug #11

wants to merge 6 commits into from

Conversation

vengroff
Copy link
Contributor

@vengroff vengroff commented Jul 19, 2024

Closes #12

@vengroff vengroff marked this pull request as draft July 19, 2024 17:55
@mikivee
Copy link
Collaborator

mikivee commented Sep 18, 2024

I was thinking more about this, and because stochastic occupancy scheduling is turned off, I actually don't think the weekend feature will provide any explanatory power at all. So maybe for right now we just trim off this feature, since it is broken anyway and it makes the convolutions more expensive. wdyt?

@vengroff
Copy link
Contributor Author

I think probably the best test is to fit the model with and without the feature and see if the validation loss is better, worse, or unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library support for weekend issue.
2 participants