-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water Insecurity Data #798
Water Insecurity Data #798
Conversation
- cleaning_script compiled from article - data_dictionary added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple relatively common things. No need for you to do anything, but FYI:
- "DESCRIPTION" and "QUESTION?" in
intro.md
are meant as placeholders. This is a super common point of confusion, so I'll work on making that more clear! - Alt text should serve as a replacement for the image whenever possible, so I added information about what the choropleths show.
Thank you so much for this submission! You'll see a few more emails as I commit my changes and then run the script to accept the submission.
/assign water-insecurity 2025-01-28 |
/assign water-insecurity 2025-01-28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Thanks , @jonthegeek ! I pulled the alt text from the html img referenced in the original article so it's helpful to know it needed to be more descriptive. Writing descriptive alt text is something I want to get better at so this was really useful feedback. |
Thank you for making this an easy first time PR for this repo! |
Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.
Usability:
Preparation:
cleaning.R
has code to download and clean the dataset, resulting in descriptively-named data.frames.saving.R
to createcsv
s andmd
data dictionaries for each of my data.frames.{dataset}.md
files.intro.md
file to introduce my dataset.png
file.meta.yaml
, including descriptive alt text for each image.meta.yaml
about how to credit me, and deleted any parts of that block that I do not want you to use.