Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Insecurity Data #798

Merged
merged 8 commits into from
Jan 19, 2025

Conversation

nnpereira
Copy link
Contributor

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

- cleaning_script compiled from article
- data_dictionary added
@nnpereira nnpereira mentioned this pull request Jan 17, 2025
15 tasks
Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple relatively common things. No need for you to do anything, but FYI:

  • "DESCRIPTION" and "QUESTION?" in intro.md are meant as placeholders. This is a super common point of confusion, so I'll work on making that more clear!
  • Alt text should serve as a replacement for the image whenever possible, so I added information about what the choropleths show.

Thank you so much for this submission! You'll see a few more emails as I commit my changes and then run the script to accept the submission.

data/curated/water-insecurity/intro.md Outdated Show resolved Hide resolved
data/curated/water-insecurity/intro.md Outdated Show resolved Hide resolved
data/curated/water-insecurity/meta.yaml Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

/assign water-insecurity 2025-01-28

@jonthegeek
Copy link
Collaborator

/assign water-insecurity 2025-01-28

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jonthegeek jonthegeek merged commit 4d0ef20 into rfordatascience:main Jan 19, 2025
@nnpereira
Copy link
Contributor Author

Just a couple relatively common things. No need for you to do anything, but FYI:

  • "DESCRIPTION" and "QUESTION?" in intro.md are meant as placeholders. This is a super common point of confusion, so I'll work on making that more clear!
  • Alt text should serve as a replacement for the image whenever possible, so I added information about what the choropleths show.

Thank you so much for this submission! You'll see a few more emails as I commit my changes and then run the script to accept the submission.

Thanks , @jonthegeek ! I pulled the alt text from the html img referenced in the original article so it's helpful to know it needed to be more descriptive. Writing descriptive alt text is something I want to get better at so this was really useful feedback.

@nnpereira
Copy link
Contributor Author

Thanks again!

Thank you for making this an easy first time PR for this repo!

@nnpereira nnpereira deleted the nnpereira/water-insecurity branch January 20, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants