Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative angles troubles. #28

Open
SKYnv opened this issue Sep 25, 2023 · 1 comment
Open

Negative angles troubles. #28

SKYnv opened this issue Sep 25, 2023 · 1 comment

Comments

@SKYnv
Copy link

SKYnv commented Sep 25, 2023

Hello. Thankyou for your great work.
Unfortunately we have some issues and it depends from some leaks in docs.

So, we use roll-pitch-yaw system.
and we have

roll= -4
pitch= -11.6
yaw= 96

And we have Cesium geospatial system they use the same and adapt some values

roll= 356
pitch= -11.6
heading=96

And we decide to use cameratransform lib instead. We start from comparing horizon and get some issues.

roll= -4
pitch= -11.6
yaw= 96

with these value we get mirrored horizon, and only this these

roll= 4
pitch= 11.6
yaw= 96

all became correct.
So can you explain documentation more about angles and correct degrees for them. And ofc formula tilt_deg = 90 - pitch_deg seems incorrect for negative values

@rgerum
Copy link
Owner

rgerum commented Sep 25, 2023

Ah ok. Yes you are right. The hint is wrong, the equation is different.
pitch_deg = tilt_deg - 90
or tilt_deg = pitch_deg + 90
Also the roll is defined with a different sign.
As I see quite a number of people use the roll-pitch-yaw system, I am wondering if it might be a good idea to also implement that system. But on the other hand it could introduce more confusion, having two systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants