-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PathBuf to AsRef<Path> in the Engine file API #693
Conversation
The use of PathBuf has been replaced with AsRef<Path> in the file API of the engine. An implementation of `From<&Path>` for Immutable `String` has been added to satisfy type constraints in `ast` module.
I suppose it would break existing code that uses syntax like |
Yes, because now the compiler does not know which type we want to pass. But this can be easily fixed by removing ".into()". |
True, but that would break a lot of existing code since I recommended I have been trying to find a way to do it generic while maintaining compatibility with |
I think we can try to add a new type that implements both |
Yeah, I have been wondering about that also. So unfortunately this will still be a major API-breaking change unless we can find ways to get rid of the |
When is the release of the new major version planned? |
None has been planned so far... unless there is a good reason to introduce major API breaks which should mean some significant changes. |
Closing this for now. Wait for |
I also tested the changes with the following code: