Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhai depends on unmaintained crate "instant" #891

Open
VorpalBlade opened this issue Jul 3, 2024 · 4 comments
Open

Rhai depends on unmaintained crate "instant" #891

VorpalBlade opened this issue Jul 3, 2024 · 4 comments

Comments

@VorpalBlade
Copy link

According to https://crates.io/crates/instant:

This crate is no longer maintained. Please consider creating a fork or using web-time instead. Or reach out if you are interested in taking over its maintenance.

rhai should probably switch?

@schungx
Copy link
Collaborator

schungx commented Jul 3, 2024

Hhhhmmm.... good catch.

Not sure if web-time would be a drop-in replacement...

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

@VorpalBlade
Copy link
Author

VorpalBlade commented Jul 3, 2024

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

Same, I was just adding rhai to a new project and was auditing the recursive dependencies it pulled in and noticed this. Since I don't target wasm I don't have any reason to work on this.

@0byteme
Copy link
Contributor

0byteme commented Aug 1, 2024

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

If use web-time instead of instant, will it cause a breaking change?

@schungx
Copy link
Collaborator

schungx commented Aug 1, 2024

As instant is primarily used only in WASM and I don't usually build for WASM... Somebody needs to test it out and let me know if everything is fine if we replace instant with web-time...

If use web-time instead of instant, will it cause a breaking change?

Not sure... I haven't used web-time before... can somebody test it out?

@0byteme 0byteme mentioned this issue Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants