Replace Detected by Transcribe for awake_wav & debug rec #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the awake sound and debug recording are triggered by
detection
. This PR changes them to be triggered bytranscribe
for the following reasons:Conceptually it's more accurate, the sounds mark the ASR period during which the user is expected to talk.
transcript
is already used to mark the end of the period, so the symmetric canonical choice is to usetranscribe
for the beginning.transcribe
is always sent by the server so the code becomes simpler and common for all satellite types, and can be moved toSatelliteBase
.Using
transcribe
prepares the code for implementing a "push to talk" feature, allowing the satellite to be activated by the server without a wake word, going directly to ASR. In this case we'll gettranscribe
withoutdetected
, but we still want the awake sound and debug recording to happen.(A separate PR for this feature will be submitted soon.)
Unless I miss something this change shouldn't break any existing setups (since transcribe
always comes immediately after
detection`). I tested a few configurations, it seemed to work fine.