Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Detected by Transcribe for awake_wav & debug rec #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chatziko
Copy link

@chatziko chatziko commented Mar 26, 2024

Currently the awake sound and debug recording are triggered by detection. This PR changes them to be triggered by transcribe for the following reasons:

  1. Conceptually it's more accurate, the sounds mark the ASR period during which the user is expected to talk. transcript is already used to mark the end of the period, so the symmetric canonical choice is to use transcribe for the beginning.

  2. transcribe is always sent by the server so the code becomes simpler and common for all satellite types, and can be moved to SatelliteBase.

  3. Using transcribe prepares the code for implementing a "push to talk" feature, allowing the satellite to be activated by the server without a wake word, going directly to ASR. In this case we'll get transcribe without detected, but we still want the awake sound and debug recording to happen.
    (A separate PR for this feature will be submitted soon.)

Unless I miss something this change shouldn't break any existing setups (since transcribealways comes immediately afterdetection`). I tested a few configurations, it seemed to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant