feature/other concise examples #958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in representations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 80.90% 80.91%
=======================================
Files 195 195
Lines 14889 14948 +59
=======================================
+ Hits 12046 12095 +49
- Misses 2843 2853 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't actually resolve #930 but does resolve bugs - previously representation was seemingly working by luck.
Currently any models within a collection that share priors are considered separately. We need to be careful about how we represent a collection of models in a way that does not obfuscate what is going on.
For example, if we used a concise representation of a collection of models which all shared a prior it would in the current representation look the same as a collection of models which all had an independent prior of with the same name and parameters.