-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: bump actions/labeler from 4 to 5 #5360
Conversation
The format of the file changed, we are using the oldest syntax:
While now we should do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recommend merging this yet. The new config format is poorly documented, the docs are self-contradictory. Somewhere it says
- any-glob-to-any-file: ['list', 'of', 'globs']
but just below, the example is
- any-glob-to-any-file: one-raw-glob
.
Which is obviously a string and not a list of globs. We already got bitten by somebody not caring about this problem for another action, so I'd recommend to wait until somebody else goes through the pain and there is a known working example that won't be bugfixed away.
Pushed something here: master...VladimirSlavik:anaconda:master-labeler-v5 |
@VladimirSlavik is there a reason to not use your changes to get this merged? |
I did not test these changes, so I don't know if they are correct. |
Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5. - [Release notes](https://github.com/actions/labeler/releases) - [Commits](actions/labeler@v4...v5) --- updated-dependencies: - dependency-name: actions/labeler dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
7873893
to
cea85e1
Compare
Verified at KKoukiou#2 |
/kickstart-test --waive infra only |
Just tested. Works as expected. |
Bumps actions/labeler from 4 to 5.
Release notes
Sourced from actions/labeler's releases.
... (truncated)
Commits
8558fd7
Merge pull request #709 from actions/v5.0.0-beta000ca75
Merge pull request #700 from MaksimZhukov/apply-suggestions-and-update-docume...cb66c2f
Update dist9181355
Apply suggestions for the beta vesrion and update the documentationefe4c1c
Merge pull request #699 from MaksimZhukov/update-node-runtime-and-dependenciesc0957ad
Run Prettier8dc8d18
Update Node.js version in reusable workflowsd0d0bbe
Update documentation1375c42
5.0.0ab7411e
Change version of Node.js runtime to node20You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)